Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ensembling methods for tiling to Anomalib #1226

Open
wants to merge 233 commits into
base: main
Choose a base branch
from

Conversation

blaz-r
Copy link
Contributor

@blaz-r blaz-r commented Aug 1, 2023

Description

This PR adds mechanism to train ensemble of models on tiled images. It is part of Google Summer of Code.

A lot of details on implementation as well as discussion can be accessed in #1131.

Closes #1727

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Some things still todo (tests, docs...) but most of the code is ready for review.

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

blaz-r and others added 25 commits October 3, 2024 16:41
Signed-off-by: blaz-r <[email protected]>
Signed-off-by: blaz-r <[email protected]>
@blaz-r
Copy link
Contributor Author

blaz-r commented Oct 6, 2024

The code and test are now refactored. I'll go over the docs again tomorrow and polish them some more.

The PR still relies on #2350 to be fixed and I guess I'll just use the workaround for #2254. I'm also not sure about the DCO, will rebasing mess anything up?

@blaz-r blaz-r marked this pull request as ready for review October 6, 2024 18:50
@samet-akcay
Copy link
Contributor

The code and test are now refactored. I'll go over the docs again tomorrow and polish them some more.

The PR still relies on #2350 to be fixed and I guess I'll just use the workaround for #2254. I'm also not sure about the DCO, will rebasing mess anything up?

Thanks @blaz-r. Not sure about #2350, we need to discuss. Concerning DCO, that's fine, you could just click the link and sign it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ensembling methods for tiling to Anomalib
6 participants