Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create): support multiple --product flags #216

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

felipecruz91
Copy link
Contributor

This PR adds supports for having multiple --product flags.

Fixes #215.

@cpanato cpanato requested a review from puerco July 9, 2024 09:05
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

i will defer to @puerco for final review

Copy link
Member

@puerco puerco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, @felipecruz91 I was concerned about the subcomponent use case and it's handled nicely. Thank you!

@puerco puerco merged commit 01f6dfa into openvex:main Jul 10, 2024
10 checks passed
@felipecruz91 felipecruz91 deleted the hotfix/multiple-products branch July 11, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple --product ignored since v0.2.5
3 participants