Added dynamodb installation script #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loujaybee
reviewed
Jan 15, 2023
| echo " " | ||
| echo "Dynamodb-local is installed and ready for use.... :) " | ||
|
|
||
|
|
There was a problem hiding this comment.
Thought: I guess we could also look into installing: https://github.com/localstack/localstack
loujaybee
reviewed
Jan 15, 2023
| rm -f dynamodb_local_latest.tar.gz | ||
|
|
||
| echo " " | ||
| echo "Dynamodb-local is installed and ready for use.... :) " |
There was a problem hiding this comment.
Would be useful to add the command to start, how to ping the local installation, and a link to the docs.
Suggested change
| echo "Dynamodb-local is installed and ready for use.... :) " | |
| echo "Dynamodb-local is installed and ready for use.... :) | |
| To run DynamoDB locally: java -Djava.library.path=./DynamoDBLocal_lib -jar DynamoDBLocal.jar -sharedDb | |
| To point AWS CLI to Local DynamoDB: aws dynamodb list-tables --endpoint-url http://localhost:8000 | |
| For more details, see the documentation: https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/DynamoDBLocal.DownloadingAndRunning.html#DynamoDBLocal.DownloadingAndRunning.title | |
| " |
loujaybee
reviewed
Jan 15, 2023
Comment on lines
+8
to
+10
| echo "java is installed sucessfully.... :) " | ||
| echo " " | ||
| echo " " |
There was a problem hiding this comment.
I think you can add \n for newline, if you wanted to.
Suggested change
| echo "java is installed sucessfully.... :) " | |
| echo " " | |
| echo " " | |
| echo "java is installed sucessfully.... :) \n\n" |
loujaybee
reviewed
Jan 15, 2023
|
|
||
| echo " " | ||
| echo "Dynamodb-local is installed and ready for use.... :) " | ||
|
|
There was a problem hiding this comment.
Would also be quite cool if we started a Makefile for the project to keep scripts together
If we added:
start-dynamodb-local:
cd dynamolocal && java -Djava.library.path=./DynamoDBLocal_lib -jar DynamoDBLocal.jar -sharedDb
To a root file called Makefile then we can have the command: make start-dynamodb-local that will run this command for us in a shorthand. Not necessary for this PR though, I've also made an issue:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a script to setup dynamodb local.