-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename selectmenu
to selectbox
#773
Comments
Not necessarily against the name change. But not a fan of the name "selectbox" and the reason behind it. The name "combobox" is derived from the idea that it is the "options box" combined with an input element, so the "listbox" + "input" = combobox. If you follow that terminology, then the "combobox" should be seen as just a part of the selectmenu (or other future name), which we have -> the listbox. So you "create a combobox by changing the listbox". And because we already have the "listbox", let's keep it at one "box" to prevent confusion and tongue twisters? |
sort of, @brechtDR. on window standard i'm not sure it's anymore confusing than what people are already having to wrap their brains around when implementing custom ARIA combobox+listbox patterns - https://www.w3.org/WAI/ARIA/apg/patterns/combobox/examples/combobox-select-only/ but shrug... if one can come up with a better name, then have at it :) i just like the idea of shelving |
Completely understand the idea of changing the name, although for me, it doesn't have to necessarily. But boxes in boxes, it might be a bit personal. But I'm kind of allergic to this kind of naming. It's also the go to naming in css class names when people are out of ideas, maybe that's why. 😅 Might need a good brainstorm session for this. I'll be thinking about it. |
The Open UI Community Group just discussed The full IRC log of that discussion<gregwhitworth> Topic: [selectmenu] Rename selectmenu to selectbox<gregwhitworth> github: https://github.com//issues/773 <una> q+ <hdv> masonf: this one may be quick… bikeshedding about selectmenu. The issue is what selectmenu has the word “menu” in it… people might want to build an action menu but that's not what selectmenu would be for, so it could be confusing <brecht_dr> q+ <gregwhitworth> ack una <hdv> masonf: the proposal in the issue would be to rename to selectbox instead of selectmenu <hdv> una: when we're talking about selectmenu in this group, is that we limit it to selectmenu experience, so that we don't have actions and things inside of the selectmenu… if we rename to 'box' we remove some of the limitations we had in the 'selectmenu' name, would make it feel more like a generic thing like a div <hdv> una: also, selectmenus aren't always box-y <gregwhitworth> +1 on selectbox seeming like listbox from a DX perspective <gregwhitworth> ack brecht_dr <scotto> q+ <hdv> brecht_dr: the word 'box' seems very generic… not against a name change but don't feel great about 'box' <gregwhitworth> ack scotto <hdv> scotto: one of the problems with the current name… if is supposed to be an updated version of the select element and it currently opens a listbox with options, that is semantically different from what a menu is. Options and menuitems are have very associations in tools like screenreaders <una> q+ <masonf> q? <gregwhitworth> ack una <hdv> scotto: if we want this to be an updated select, removing the word menu makes sense to me as it semantically isn't a menu <masonf> q+ <hdv> una: feels like this brings me back to listbox… it feels like a selectlist almost <Westbrook> q+ <hdv> una: maybe that could work… the colloquial word would be select menu when you're selecting items in a list <gregwhitworth> ack masonf <hdv> masonf: the intention is definitely to replace the <select> not a menu <gregwhitworth> ack Westbrook <hdv> Westbrook: two quick things: in naming it not menu, we're in a world where input[type=checkbox] is often used to show and hide a menu… basically I want to say… people can use this stuff in all sorts of ways we can't imagine <hdv> Westbrook: in the Spectrum ecosystem we call this pattern a picker <hdv> gregwhitworth: in Salesforce world we're going to call this a picklist <flackr> chooser is another synonym we could... choose <hdv> gregwhitworth: let's try to resolve this async <una> `selectlist` <una> `<select type="list">` <hdv> annevk: tangential question… is it explained in more detail anywhere why we can't extend `<select>` further? <hdv> gregwhitworth: the original explainer has some info <hdv> masonf: and there are lots of issues where we talked about this <hdv> annevk: I read the current one, it's very light on background <hdv> gregwhitworth: we do have a lot of issues that we discussed <hdv> Jen: can you summarise the issue? <hdv> gregwhitworth: there are security concerns if you can put anytihng inside an option <hdv> gregwhitworth: also the parts that we're able to use in selectmenu, fully styleable and composeable, would be hard to do in select <hdv> dandclark: another I can add is parser troubles… like when you want to use style els in selectmenu, in the current select the parser would kick you out of the select… it's not super clear how we could work around that <hdv> [annevk in chat: “It drops them, it doesn't exit <select> ”] <hdv> masonf: maybe it makes sense to open a fresh issue for this question? as we have some new people in the call <hdv> gregwhitworth: or we could create a one pager, that would be my preference <hdv> gregwhitworth: that would be easier to find later on than an isuse <hdv> s/isuse/issue <hdv> annevk: thanks it would help a lot for us <hdv> annevk: to figure out what sort of limitations make it impossible |
Generally, there was some support and some pushback to renaming away from Other suggestions heard during the meeting:
Please feel free to weigh in or suggest additional names. |
if the name is to be changed, i think selectlist, picker or picklist would be fine replacements. |
I agree that Another name that comes to mind for me is |
I would prefer not to use |
+1 for list has the same issues than menu no? it could be argued that selectmenu is still a form of a menu. the select element is also not aligned with the abstract select role |
they're similar in high level UX interaction, but options are meant for selecting/returning a value typically used in form submission / validation. where as a menuitemradio are more associated with performing an action in and of itself. different expectations for the end user who is aware of what these different roles suggest per their intended use.
The |
+1 to @scottaohara. They appear similar, but menus should never be form controls. I think |
my reasoning was more like how can a specific "select" named element which holds a listbox and button be 1 to 1 to the aria abstract select role for four form widgets, listbox, menu, radiogroup, and tree. it's not a direct mapping. sure the select element has some aria select behavior but the select element does more |
understood. tbh i wouldn't be so concerned with that. there are other abstract roles which also likely would not align with people's general understanding of the actual UI components that users interact with, and aren't reflective of their names to boot. but most web developers shouldn't even need to know or care about such things, since they're (abstract roles) not be used by them anyway. |
I like |
I agree with this. The only doubt I have is that I don't have anything to back this up, just a feeling. |
Few options from AI
Try 2
And I have to say |
Ok, if I'm going to try and sum up the potential options (sorry AI I'm not going to list all 60):
Please use the emoji button on Github that relates to the option you'd like to vote. Please vote only once. |
The Open UI Community Group just discussed The full IRC log of that discussion<gregwhitworth> Topic: Rename selectmenu to selectbox<gregwhitworth> github: https://github.com//issues/773#issuecomment-1649976535 <hdv> masonf: this issue probably needs more time and interest. It's about renaming selectmenu to something else <hdv> masonf: current winner by one iks 'selectbox', close runner up is 'picklist' <bkardell_> q+ <hdv> masonf: this isn't definitive enough that we should resolve on it today <hdv> s/iks/is <bkardell_> q- <hdv> masonf: people who are on social media, please share it so we get more votes in |
As I mentioned in the conversation last week, I think
By the definition we've discussed thus far, these components cannot contain other interactive components, so they are always a list of options. |
How about |
It’s not always a list either - for example emoticon picker or color
picker. But It always has a picker and options ;)
W dniu czw., 27.07.2023 o 20:23 Una Kravets ***@***.***>
napisał(a):
… As I mentioned in the conversation last week, I think SelectList is more
descriptive than SelectBox because:
1. It's not always a "box" in shape
2. It's a container for a list of options
—
Reply to this email directly, view it on GitHub
<#773 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFKBQQKV5DM4Y2BKOE3TBP3XSKW3JANCNFSM6AAAAAAZNOYKM4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
From an accessibility standpoint, these would actually be an entirely different interaction pattern ( |
Emoticon and color picker are both lists to me :) list of emojis or list of colors |
My first instinct was also to go with However there are already list elements in html with
So the best compromise remaining seems to be |
Considering names such as color-picker or date-picker, why not option-picker? This explains the semantics without stating any specific presentation style, which (one assumes) could be radically adjusted via CSS. |
Apologies if this has already been suggested but what about Could be confused for people talking about a |
The Open UI Community Group just discussed
The full IRC log of that discussion<gregwhitworth> Topic: Rename selectmenu to selectbox<gregwhitworth> github: https://github.com//issues/773#issuecomment-1649976535 <hdv> gregwhitworth: we'll timebox this naming discussion to 10 mins <hdv> masonf: the stated problem with selectmenu is that it isn't a “menu” and shouldn't be thought of as a menu <hdv> masonf: there was a vote and some people shared it on their social media… we got quite a few more votes, with most votes, kind of close up, for selectlist and selectbox <gregwhitworth> q? <hdv> q+ <una> q+ <gregwhitworth> ack hdv <gregwhitworth> hdv: I didn't vote for one of the winners but I agree with una that isn't a box so I agree with that approach <gregwhitworth> ack una <gregwhitworth> +1 to selectlist <hdv> una: I left some comments in the issue… 'list' feels more semantic than box, box is a shape, there's always a list of options involved <brecht_dr> q+ <hdv> una: we'll talk about listbox in a few minutes, it seems like it may become an element… if that's the case that would likely become very confusing, if we have both listbox and selectbox <hdv> una: the comment on datepicker and colorpicker was interesting… re selectpicker <gregwhitworth> ack brecht_dr <hdv> gregwhitworth: at salesforce we call it picklists <flackr> itempicker <hdv> brecht_dr: wanted to confirm what Una said… box is like old school naming, not very descriptive <hdv> brecht_dr: it clicks more with listbox inside of list too <gregwhitworth> one positive that I like about selectlist over picklist is that it's replacing select <hdv> brecht_dr: as a non native speaker 'list' sounds better to me <hdv> [ the votes change in real time in the GH issue, 27 for selectlist, 20 for selectbox ] <masonf> Proposed resolution: rename `<selectmenu>` to `<selectlist>`. <hdv> gregwhitworth: for selectlist it probably is also more likely for people who know what it means <masonf> Let's call it the <bikeshed> element <hdv> una: one point in favour of `<selectpicker>`, which wasn't on vote, is when thinking about elements that go inside of `selectlist`, like listbox and `button`, but not `listitem`, maaybe `selectpicker` is… better? <scotto> +1 mason <hdv> flackr: but then it's like picking a select <hdv> gregwhitworth: is this a formal objection? <masonf> RESOLVED: rename `<selectmenu>` to `<selectlist>`. <hdv> una: no |
This was decided in OpenUI here: openui/open-ui#773 Bug: 1121840 Change-Id: If3bc31860a48e0f3842481774cb874cbd42a8bb7
This was decided in OpenUI here: openui/open-ui#773 Bug: 1121840 Change-Id: If3bc31860a48e0f3842481774cb874cbd42a8bb7
This was decided in OpenUI here: openui/open-ui#773 Bug: 1121840 Change-Id: If3bc31860a48e0f3842481774cb874cbd42a8bb7
This was decided in OpenUI here: openui/open-ui#773 Bug: 1121840 Change-Id: If3bc31860a48e0f3842481774cb874cbd42a8bb7
This was decided in OpenUI here: openui/open-ui#773 Bug: 1121840 Change-Id: If3bc31860a48e0f3842481774cb874cbd42a8bb7
This was decided in OpenUI here: openui/open-ui#773 Bug: 1121840 Change-Id: If3bc31860a48e0f3842481774cb874cbd42a8bb7
This was decided in OpenUI here: openui/open-ui#773 Bug: 1121840 Change-Id: If3bc31860a48e0f3842481774cb874cbd42a8bb7
This was decided in OpenUI here: openui/open-ui#773 Bug: 1121840 Change-Id: If3bc31860a48e0f3842481774cb874cbd42a8bb7
This was decided in OpenUI here: openui/open-ui#773 Bug: 1121840 Change-Id: If3bc31860a48e0f3842481774cb874cbd42a8bb7
This was decided in OpenUI here: openui/open-ui#773 Bug: 1121840 Change-Id: If3bc31860a48e0f3842481774cb874cbd42a8bb7
This was decided in OpenUI here: openui/open-ui#773 Bug: 1121840 Change-Id: If3bc31860a48e0f3842481774cb874cbd42a8bb7
This was decided in OpenUI here: openui/open-ui#773 Bug: 1121840 Change-Id: If3bc31860a48e0f3842481774cb874cbd42a8bb7
This was decided in OpenUI here: openui/open-ui#773 Bug: 1121840 Change-Id: If3bc31860a48e0f3842481774cb874cbd42a8bb7
This was decided in OpenUI here: openui/open-ui#773 Bug: 1121840 Change-Id: If3bc31860a48e0f3842481774cb874cbd42a8bb7
This was decided in OpenUI here: openui/open-ui#773 Bug: 1121840 Change-Id: If3bc31860a48e0f3842481774cb874cbd42a8bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4754199 Auto-Submit: Joey Arhar <[email protected]> Reviewed-by: Chris Bookholt <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1182736}
This was decided in OpenUI here: openui/open-ui#773 Bug: 1121840 Change-Id: If3bc31860a48e0f3842481774cb874cbd42a8bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4754199 Auto-Submit: Joey Arhar <[email protected]> Reviewed-by: Chris Bookholt <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1182736}
This was decided in OpenUI here: openui/open-ui#773 Bug: 1121840 Change-Id: If3bc31860a48e0f3842481774cb874cbd42a8bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4754199 Auto-Submit: Joey Arhar <[email protected]> Reviewed-by: Chris Bookholt <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1182736}
This was decided in OpenUI here: openui/open-ui#773 Bug: 1121840 Change-Id: If3bc31860a48e0f3842481774cb874cbd42a8bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4754199 Auto-Submit: Joey Arhar <[email protected]> Reviewed-by: Chris Bookholt <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1182736}
Automatic update from web-platform-tests Rename selectmenu to selectlist This was decided in OpenUI here: openui/open-ui#773 Bug: 1121840 Change-Id: If3bc31860a48e0f3842481774cb874cbd42a8bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4754199 Auto-Submit: Joey Arhar <[email protected]> Reviewed-by: Chris Bookholt <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1182736} -- wpt-commits: a5385871e8031c74c4646eacc035720a5371468d wpt-pr: 41374
Automatic update from web-platform-tests Rename selectmenu to selectlist This was decided in OpenUI here: openui/open-ui#773 Bug: 1121840 Change-Id: If3bc31860a48e0f3842481774cb874cbd42a8bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4754199 Auto-Submit: Joey Arhar <[email protected]> Reviewed-by: Chris Bookholt <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1182736} -- wpt-commits: a5385871e8031c74c4646eacc035720a5371468d wpt-pr: 41374
This was decided in OpenUI here: openui/open-ui#773 Bug: 1121840 Change-Id: If3bc31860a48e0f3842481774cb874cbd42a8bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4754199 Auto-Submit: Joey Arhar <[email protected]> Reviewed-by: Chris Bookholt <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1182736}
This was decided in OpenUI here: openui/open-ui#773 Bug: 1121840 Change-Id: If3bc31860a48e0f3842481774cb874cbd42a8bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4754199 Auto-Submit: Joey Arhar <[email protected]> Reviewed-by: Chris Bookholt <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1182736}
The name "selectmenu" is a poor choice for the current interaction because it does not follow the "menu" pattern.
I have frequently seen developers use the term "menu" to describe any interaction with a popup. This leads to confusion when trying to compose interfaces from well-supported accessible patterns. Using the term "menu" for what's really a combobox here will further propagate this confusion.
I propose "selectbox" as an alternative. This name is both more concise and more accurate in its alignment with "combobox".
The text was updated successfully, but these errors were encountered: