UCT/IB/UD: Fix typedef for iface address #6083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosefe
reviewed
Dec 31, 2020
| @@ -40,7 +40,7 @@ typedef uint16_t uct_ud_psn_t; | |||
| typedef struct uct_ud_iface uct_ud_iface_t; | |||
| typedef struct uct_ud_ep uct_ud_ep_t; | |||
| typedef struct uct_ud_ctl_hdr uct_ud_ctl_hdr_t; | |||
| typedef uct_ib_qpnum_t uct_ud_iface_addr_t; | |||
| typedef struct uct_ud_iface_addr uct_ud_iface_addr_t; | |||
There was a problem hiding this comment.
can we also delete uct_ib_qpnum_t ?
dmitrygx
force-pushed
the
topic/uct/ib_ud_addr
branch
from
5174cb2 to
0ff146a
Compare
yosefe
approved these changes
Dec 31, 2020
|
@yosefe ok to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix typedef for iface address
Why ?
It has to be
typedefforstruct uct_ud_iface_addrHow ?
Replace
uct_ib_qpnum_tbystruct uct_ud_iface_addr