TEST/TAG: Fix tag test to check inline data flag #5961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrygx
approved these changes
Nov 27, 2020
| @@ -388,6 +388,9 @@ class test_tag : public uct_test { | |||
| recv_ctx *user_ctx = ucs_container_of(self, recv_ctx, uct_ctx); | |||
| user_ctx->sw_rndv = true; | |||
| user_ctx->status = status; | |||
| if (flags & UCT_TAG_RECV_CB_INLINE_DATA) { | |||
There was a problem hiding this comment.
[minor/imp] can reduce duplication:
static void sw_rndv_completed(uct_tag_context_t *self, uct_tag_t stag,
const void *header, unsigned header_length,
ucs_status_t status, unsigned flags)
{
recv_ctx *user_ctx = ucs_container_of(self, recv_ctx, uct_ctx);
user_ctx->sw_rndv = true;
if (flags & UCT_TAG_RECV_CB_INLINE_DATA) {
memcpy(user_ctx->mbuf->ptr(), header, header_length);
}
completed(self, stag, 0, header_length, NULL, status);
}
yosefe
force-pushed
the
topic/test-tag-fix-tag-test-to-check
branch
from
578405d to
99237a7
Compare
dmitrygx
approved these changes
Nov 27, 2020
dmitrygx
approved these changes
Nov 28, 2020
|
/azp run |
|
bot:pipe:retest |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
brminich
approved these changes
Nov 28, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bureddy
approved these changes
Nov 28, 2020
|
merging since test failure is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
UCT test must copy-out inline data, following #5889
@bureddy