Fixed gasp support bugs per #738

[Balearica]

Context

See #738. In short, write support for the gasp table was implemented recently in #595, however is broken. Any font written by opentype.js that includes a gasp table cannot be re-imported by opentype.js.

Changes

This PR makes two changes to resolve. First, it fixes the typo in the gasp write function, which was trying to iterate over the integer gasp.numRanges rather than the array gasp.gaspRanges. Second, it wraps the entire gasp read function in a try block. This should prevent any future issues where failing to parse this optional table prevents a font from being read.

How Has This Been Tested?

I confirmed that the Changa-Regular.ttf font could be saved/read using toArrayBuffer/opentype.parse, which (as described in #738) previously resulted in an error.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I did npm run test and all tests passed green (including code styling checks).
• I have added tests to cover my changes.
• My change requires a change to the documentation.
• I have updated the README accordingly.
• I have read the Contribute README section.

[Connum]

Please add a test that will prevent this issue from being reintroduced in the future.

[Balearica]

I added a test that confirms fonts written with a gasp table can be read, and that the gasp table is identical to the original.

[Connum]

I added a test that confirms fonts written with a gasp table can be read, and that the gasp table is identical to the original.

Very nice, thanks! We shall have a review on this fix soon.

[yne]

thanks for the fix :)
just 2 simple questions/suggestion but no issue overall

[Connum]

Hi, (why) are we waiting for another review? It looks to me as if this is ready to be merged.

[yne]

Hi, (why) are we waiting for another review? It looks to me as if this is ready to be merged.

I've approved but the repo owner seems to want 2 approval, and @ILOVEPIE don't seems available to approve.

can't you also approve ? so there is no need to bypass the process and force the merge