Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement reading, writing and drawing of CFF PaintType and StrokeWidth #651

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

Connum
Copy link
Contributor

@Connum Connum commented Nov 26, 2023

Description

Implemented reading, drawing and writing of CFF1 PaintType and StrokeWidth

Motivation and Context

CFF1 PaintType and StrokeWidth wasn't handled and single line fonts were thus handled incorrectly
fix #459

How Has This Been Tested?

Screenshots (if appropriate):

before:
image

after:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I did npm run test and all tests passed green (including code styling checks).
  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the README accordingly.
  • I have read the CONTRIBUTING document.

@Connum Connum added enhancement Spec Related to the implementation of the Opentype specification labels Nov 26, 2023
@Connum Connum added this to the Release 2.0.0 milestone Nov 26, 2023
@Connum Connum requested review from ILOVEPIE and yne November 26, 2023 21:59
@Connum
Copy link
Contributor Author

Connum commented Nov 26, 2023

@brawer this might be something for you?
This is the test file I created: CFF1SingleLinePaintTypeTEST.zip

@Connum Connum merged commit 6c55400 into opentypejs:master Nov 30, 2023
1 check passed
@Connum Connum deleted the fix/459 branch November 30, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Spec Related to the implementation of the Opentype specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Open Contour Fonts?
2 participants