Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change npm start command to output module version #624

Closed
wants to merge 2 commits into from

Conversation

Connum
Copy link
Contributor

@Connum Connum commented Oct 20, 2023

Description

changes the npm start command to output the module version

Motivation and Context

The doc html pages already use the module version, but when using the local dev server via npm start, it updated the iife version instead. So there was no automatic reloading and the module had to be manually compiled in order to see the changes after a reload.

How Has This Been Tested?

Ran the dev server and made changes, which were immediately reflected by reloading.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Not applicable to this change only affecting the dev experience. I'm going to directly merge that for that reason as well.

@Connum Connum added the dev Changes revolving merely around dev-related code like testing, build process, etc. label Oct 20, 2023
@Connum Connum force-pushed the dev/npm-start-module branch from 8ada639 to 71f4d1c Compare October 20, 2023 06:17
@Connum
Copy link
Contributor Author

Connum commented Oct 20, 2023

aw damn, I was on the wrong branch...

@Connum Connum closed this Oct 20, 2023
@Connum Connum deleted the dev/npm-start-module branch October 20, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Changes revolving merely around dev-related code like testing, build process, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants