Fix keys retrieval in objectsEqual function (#665)

* Fix keys retrieval in objectsEqual function * added a test case that was actually failing before the fix --------- Co-authored-by: Constantin Groß <[email protected]>
opentypejs · Mar 22, 2024 · 6408975 · 6408975
1 parent fda7e3b
commit 6408975
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/src/util.js b/src/util.js
@@ -33,8 +33,8 @@ function arraysEqual(ar1, ar2) {
 function objectsEqual(obj1, obj2) {
     const val1 = Object.values(obj1);
     const val2 = Object.values(obj2);
-    const keys1 = Object.values(obj1);
-    const keys2 = Object.values(obj2);
+    const keys1 = Object.keys(obj1);
+    const keys2 = Object.keys(obj2);
 
     return arraysEqual(val1, val2) && arraysEqual(keys1, keys2);
 }

diff --git a/test/util.js b/test/util.js
@@ -0,0 +1,18 @@
+import assert from 'assert';
+import { objectsEqual } from '../src/util.js';
+
+describe('util.js', function() {
+    describe('objectsEqual', function() {
+        it('should return true for equal objects', function() {
+            assert.equal(objectsEqual({}, {}), true);
+            assert.equal(objectsEqual({ foo: 23 }, { foo: 23 }), true);
+        });
+
+        it('should return false for unequal objects', function() {
+            assert.equal(objectsEqual({}, { foo: 23 }), false);
+            assert.equal(objectsEqual({ foo: 23 }, { bar: 23 }), false);
+            assert.equal(objectsEqual({ foo: 23 }, { bar: 42 }), false);
+            assert.equal(objectsEqual({ foo: 23, bar: 42 }, { foo: 23 }), false);
+        });
+    });
+});