fix hasChar() for CMAP fonts and add tests (fix #330)

opentypejs · Oct 30, 2023 · 2570773 · 2570773
1 parent 7a1b1ac
commit 2570773
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/font.js b/src/font.js
@@ -124,7 +124,7 @@ function Font(options) {
  * @return {Boolean}
  */
 Font.prototype.hasChar = function(c) {
-    return this.encoding.charToGlyphIndex(c) !== null;
+    return this.encoding.charToGlyphIndex(c) > 0;
 };
 
 /**

diff --git a/test/font.js b/test/font.js
@@ -92,4 +92,17 @@ describe('font.js', function() {
         });
 
     });
+
+    describe('hasChar', function() {
+        it('returns correct results for non-CMAP fonts', function() {
+            assert.equal(font.hasChar('i'), true);
+            assert.equal(font.hasChar('x'), false);
+        });
+
+        it('returns correct results for CMAP fonts', function() {
+            const cmapFont = loadSync('./test/fonts/TestCMAP14.otf');
+            assert.equal(cmapFont.hasChar('a'), false);
+            assert.equal(cmapFont.hasChar('≩'), true);
+        });
+    });
 });