Trip form custom icons #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evansiroky
reviewed
Mar 13, 2020
evansiroky
approved these changes
Mar 14, 2020
fpurcell
reviewed
Mar 17, 2020
There was a problem hiding this comment.
I still see the storybook cranking out files to console.log. Would be good to get a fix in place for that.
e.g., when visiting story "Settings Selector Panel Styled":
@storybook/source-loader was applied to a file which does not contain a story. Please check your webpack configuration and make sure to apply @storybook/source-loader only to files containg stories. Related file:
fpurcell
reviewed
Mar 17, 2020
fpurcell
requested changes
Mar 17, 2020
There was a problem hiding this comment.
I'd like to see the Storybook warnings (see #79) being pumped out to console.log fixed. The storybook / props obj v. str issue is also something that would be good see to fixed.
That said, let me know if now is not the right time to fix, and I'll switch to approve.
fpurcell
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #87 by allowing implements to pass custom icons into
SettingsSelectorPanelthe way OTP-react-redux does, so implementers can optionally use icons in the mode selection pane other than the ones from the OTP-UI icons package. In particular, in OTP-UI icons, the "Take Transit" icon is the TriMet's logo, so with this PR, implementers will be able to change it.This PR also fixes improper knob types used in some storybook stories.