Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make query-gen agnostic to OTP plan query params #781

Merged

Conversation

binh-dam-ibigroup
Copy link
Collaborator

This PR makes query-gen agnostic to OTP query params it doesn't process.

When merged, #696 could be closed.

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much better. Can't believe I didn't do this originally, looks so obvious now.

@binh-dam-ibigroup binh-dam-ibigroup added the BLOCKERS Blockers exist outside of otp-ui (e.g., backend, service, etc...) label Sep 30, 2024
walkReluctance,
walkSpeed,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@binh-dam-ibigroup binh-dam-ibigroup removed the BLOCKERS Blockers exist outside of otp-ui (e.g., backend, service, etc...) label Oct 11, 2024
@binh-dam-ibigroup binh-dam-ibigroup merged commit de16f32 into opentripplanner:master Oct 11, 2024
2 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the param-agnostic-querygen branch October 11, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants