fix: add areaStops layer support
#722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binh-dam-ibigroup
requested changes
Mar 18, 2024
Do you have an idea of how to do this elegantly? The current mock response is a crazy hack that I'm not eager to recreate/expand |
binh-dam-ibigroup
requested changes
Apr 10, 2024
There was a problem hiding this comment.
Sorry for the delayed review, it took me a while decide to build an OTP instance with areaStops. It is nice that areas are showing without using too much code. I would reduce the opacity in the layers as indicated, so that map background features remain visible. How/where are circles supposed to be shown?
binh-dam-ibigroup
requested changes
Apr 15, 2024
refactor(otp2-tile-overlay): Refactor route color expression.
|
It's lovely thanks |
binh-dam-ibigroup
approved these changes
Apr 19, 2024
amy-corson-ibigroup
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add support for the new OTP areaStops layer. I feel like implementation is not perfect. Looking for advice