Improve mode setting value casting, remove "default" mode settings #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce with new mode selector
This reverts commit c425164.
Co-authored-by: Miles Grant <[email protected]> Co-authored-by: Daniel Heppner <[email protected]>
Co-authored-by: Daniel Heppner <[email protected]>
This reverts commit 2801dca.
# [@opentripplanner/trip-form-v3.1.5](https://github.com/opentripplanner/otp-ui/compare/@opentripplanner/trip-form-v3.1.4...@opentripplanner/trip-form-v3.1.5) (2023-08-09) ### Bug Fixes * **trip-form:** fix dropdown/hover bug in firefox ([c567269](opentripplanner@c567269))
# [@opentripplanner/trip-form-v3.2.0](https://github.com/opentripplanner/otp-ui/compare/@opentripplanner/trip-form-v3.1.5...@opentripplanner/trip-form-v3.2.0) (2023-08-10) ### Features * **trip-form:** support config mode subsetting ([bc682aa](opentripplanner@bc682aa))
… trip.tripHeadsign. BREAKING CHANGE: trip.tripHeadsign is no longer returned by the plan queries made by query-gen.
# [@opentripplanner/core-utils-v10.0.0](https://github.com/opentripplanner/otp-ui/compare/@opentripplanner/core-utils-v9.0.3...@opentripplanner/core-utils-v10.0.0) (2023-08-17) ### Bug Fixes * **core-utils:** Add field leg.headsign to graphql plan query, remove trip.tripHeadsign. ([27ef271](opentripplanner@27ef271)) * **core-utils:** add walk speed to query ([2d55c1b](opentripplanner@2d55c1b)) * **core-utils:** remove old walkSpeed query-param to reduce interference with new mode selector ([2438812](opentripplanner@2438812)) ### BREAKING CHANGES * **core-utils:** trip.tripHeadsign is no longer returned by the plan queries made by query-gen.
daniel-heppner-ibigroup
changed the title
binh-dam-ibigroup
approved these changes
Aug 22, 2023
amy-corson-ibigroup
approved these changes
Aug 22, 2023
amy-corson-ibigroup
assigned daniel-heppner-ibigroup and unassigned amy-corson-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the default mode settings since there was so much variety between deployments that we figure it's better to configure them per deployment. It also improves the casting of the mode setting types.