Itinerary Body: migrate to OTP2 trip props #640
Conversation
packages/itinerary-body/src/TransitLegBody/view-trip-button.tsx
Outdated
Show resolved
Hide resolved
|
I think we have to make a breaking change. OTP1 is no longer supported, so it makes no sense to support it here. I will modify the commit message |
miles-grant-ibigroup
force-pushed
the
otp2-trip-migration
branch
from
d926733
to
6bc7f1e
Compare
miles-grant-ibigroup
force-pushed
the
otp2-trip-migration
branch
from
6bc7f1e
to
3599dc4
Compare
# Conflicts: # yarn.lock
packages/itinerary-body/src/TransitLegBody/view-trip-button.tsx
Outdated
Show resolved
Hide resolved
|
Updating the mocks would be a 2-release process... |
Why? The mocks are in the itinerary-body package. |
Wait sorry, I got myself confused. Mocks are updated |
|
I'm not sure what's going on... The new mocks aren't showing up in the GitHub diffs either, but they are showing up in my local git commit history |
|
Looks like everything is updated now, please try again @binh-dam-ibigroup |
There was a problem hiding this comment.
See https://github.com/opentripplanner/otp-ui/pull/640/files#r1310695054 that was the point of doing this PR...
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
| leg?.trip?.arrivalStoptime?.stopPosition | ||
| } | ||
| toIndex={leg.to?.stopIndex} | ||
| toStopId={leg?.to?.stopId} |
There was a problem hiding this comment.
unneeded question mark
There was a problem hiding this comment.
What happens if there is no to?
| leg?.trip?.departureStoptime?.stopPosition | ||
| } | ||
| fromIndex={leg.from?.stopIndex} | ||
| fromStopId={leg?.from?.stopId} |
There was a problem hiding this comment.
unneded question mark
There was a problem hiding this comment.
What happens if there is no from
The OTP1 trip props are no longer in use, and are fundamentally incompatible with the OTP2 props. This PR resolves this incongruity.