Core add leg route names #634
Conversation
binh-dam-ibigroup
force-pushed
the
core-add-leg-route-names
branch
from
40ff7ca
to
97f7254
Compare
binh-dam-ibigroup
force-pushed
the
core-add-leg-route-names
branch
from
97f7254
to
6c3bc38
Compare
There was a problem hiding this comment.
LGTM. What do you think about adding a function that gets a route label? I think we might already have on in OTP-RR, but might be good to have here instead.
There was a recent PR where I contributed a fix where a function like this would have been useful:
opentripplanner/otp-react-redux@a05c6bd
packages/core-utils/src/itinerary.ts
Outdated
| leg: Pick<Leg, "route" | "routeShortName"> | ||
| ): string => { | ||
| const { route, routeShortName } = leg; | ||
| if (typeof route === "string") { |
There was a problem hiding this comment.
Let's add a comment to this that explains this block only applies for OTP1.
There was a problem hiding this comment.
Added in 1b3839f.
packages/core-utils/src/itinerary.ts
Outdated
| return route?.shortName; | ||
| }; | ||
|
|
||
| /** Extract the route ling name for a leg returned from OTP1 or OTP2. */ |
There was a problem hiding this comment.
Typo: ling name
There was a problem hiding this comment.
Thanks, fixed in 1b3839f.
daniel-heppner-ibigroup
assigned binh-dam-ibigroup and unassigned daniel-heppner-ibigroup
I found a use of that logic in the fare table, so I will add it. How should that be named? |
…o not rely on typeof route ===
|
@daniel-heppner-ibigroup Let me know what you think of 41e4aab with the new function (and revised logic). |
daniel-heppner-ibigroup
assigned binh-dam-ibigroup and unassigned daniel-heppner-ibigroup
Requires #632.
This PR centralizes logic to extract a route short/long name from a Leg object.