add fareproducts to query + update internal dependencies #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add-fareproducts-to-query
daniel-heppner-ibigroup
changed the title
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and binh-dam-ibigroup and unassigned binh-dam-ibigroup
|
The dependencies were a big problem for some reason, so I updated internal dependencies. |
daniel-heppner-ibigroup
changed the title
|
@daniel-heppner-ibigroup Is the intent to only release a new package for core-utils? Note that commit 15d741e will not trigger a release for the other ones you've updated. |
|
Yes, we only need a release for core-utils. @binh-dam-ibigroup edit: nevermind, Miles convinced me to make it a fix commit |
miles-grant-ibigroup
approved these changes
Jul 17, 2023
daniel-heppner-ibigroup
force-pushed
the
gql-transition/add-fareproducts-to-query
branch
from
15d741e
to
8c9c271
Compare
binh-dam-ibigroup
approved these changes
Jul 17, 2023
daniel-heppner-ibigroup
merged commit 07fabec
into
opentripplanner:master
2 checks passed
daniel-heppner-ibigroup
deleted the
gql-transition/add-fareproducts-to-query
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the fare update PR, it seems like these changes somehow got overwritten so they didn't make it in. This will generate a fix release that updates the GraphQL query for the new schema. It also updates the schema by copying it from the latest version of OTP.
Also, it runs prettier to format the GraphQL file, since it turns out Prettier supports that natively!