Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location field improvements #29

Merged
merged 10 commits into from
Jan 16, 2020

Conversation

evansiroky
Copy link
Contributor

This PR has the following improvements:

This PR is built on top of #28

*/
timestamp: PropTypes.number,
/**
* One of: 'home', 'work', 'stop' or 'recent'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these "suggested" icon ids? In that case it should state so.

export const userLocationType = PropTypes.shape({
id: PropTypes.string,
/**
* Can be either 'home', 'work', or null
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these "suggested" icon ids? In that case it should state so.

Copy link
Member

@fpurcell fpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I see the different icons for stops / stations / etc...

(Thinking that in a future update, we can add TriMet designer approved icons for these, and add them to the icons component, etc... But this should help AltSource now. Good job, Evan)

@fpurcell fpurcell merged commit 33757a3 into opentripplanner:master Jan 16, 2020
@evansiroky evansiroky deleted the location-field-improvements branch January 24, 2020 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants