-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Location field improvements #29
Location field improvements #29
Conversation
*/ | ||
timestamp: PropTypes.number, | ||
/** | ||
* One of: 'home', 'work', 'stop' or 'recent' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these "suggested" icon ids? In that case it should state so.
export const userLocationType = PropTypes.shape({ | ||
id: PropTypes.string, | ||
/** | ||
* Can be either 'home', 'work', or null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these "suggested" icon ids? In that case it should state so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I see the different icons for stops / stations / etc...
(Thinking that in a future update, we can add TriMet designer approved icons for these, and add them to the icons component, etc... But this should help AltSource now. Good job, Evan)
This PR has the following improvements:
This PR is built on top of #28