Fix story warnings and console dumps #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat renders both plain and styl DateTimeSelector story was also combined into components.story. Fix warning in from-to-location-picker.
Merged
evansiroky
approved these changes
Mar 19, 2020
… branch 'master' into fix-story
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #79 by rendering changing the Storybook story structure as follows:
components.story, each component is defined only once and rendered using a story file-level decorator.The PR also fixes a warning in one story for the
FromToLocationPickercomponent.There are no changes to the code of the components themselves.
The new layout in Storybook is illustrated with the screenshots below.
