Custom GraphQL and Mobility Profile Routing #1292
Open
+105
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 18, 2024
josh-willis-arcadis
approved these changes
Oct 18, 2024
miles-grant-ibigroup
requested changes
Oct 30, 2024
lib/main.js
Outdated
Comment on lines
37
to
48
| // Loads a JavaScript file which is set in the webpack section of the craco.config.js file. | ||
| // This setting is defined from a custom environment setting passed into webpack or | ||
| // defaults to ./config.js | ||
| // defined in webpack config: | ||
| // The JS_CONFIG variable is passed to this file by webpack's `DefinePlugin` that replaces the variable | ||
| // with its content at compile time (like C's `#define` preprocessor directive). | ||
| // eslint-disable-next-line no-undef | ||
| const jsConfig = require(JS_CONFIG).configure(otpConfig) | ||
|
|
||
| // Plug the plan query into the config (if available) | ||
| otpConfig.api.planQuery = jsConfig.planQuery | ||
|
|
There was a problem hiding this comment.
Do we still need this? Why not just put it in the js config?
There was a problem hiding this comment.
This puts the custom query into the redux state, so it can be retrieved from actions.
There was a problem hiding this comment.
I updated the comment in e60f694.
craco.config.js
Outdated
| @@ -65,6 +67,13 @@ module.exports = { | |||
| } | |||
| addBeforeLoader(webpackConfig, loaderByName('file-loader'), yamlLoader) | |||
|
|
|||
| // Support YAML | |||
There was a problem hiding this comment.
Comment needs updating
There was a problem hiding this comment.
Thanks, updated in 3726007
Comment on lines
+1051
to
+1053
| if (config.mobilityProfile) { | ||
| baseQuery.mobilityProfile = loggedInUser?.mobilityProfile?.mobilityMode | ||
| } |
There was a problem hiding this comment.
Do we have a GMAP specific branch for otp-rr? Do we want to bring this into dev?
There was a problem hiding this comment.
Not yet, although try to move specific stuff to config would be best.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR sets up craco to accept custom plan GraphQL files (or use a default one).
Custom plan query files are passed through the custom
config.jsand placed in the redux state at startup.For configuration-enabled mobility profiles, that new parameter is added to the variables passed to the GraphQL
planquery.To test, ensure that planning trips with mobility profiles produce different results based on the profiles, and that on configs without mobility profiles, planning trips is not affected.
PR Checklist: