Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(advanced-trip-form): Add autoPlan to advanced trip form #1291

Merged
merged 8 commits into from
Oct 31, 2024

Conversation

amy-corson-ibigroup
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup commented Oct 16, 2024

Description:

Add autoPlan to advanced trip form. If autoPlan is on, and there are validation errors in the location field, do not call the plan trip function.

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

@amy-corson-ibigroup amy-corson-ibigroup changed the title feat(advanced-trip-form): Add autoPlan to feat(advanced-trip-form): Add autoPlan to advanced trip form Oct 16, 2024
Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach here and I think it works nicely!

Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amy-corson-ibigroup amy-corson-ibigroup merged commit f3866d2 into dev Oct 31, 2024
9 checks passed
@amy-corson-ibigroup amy-corson-ibigroup deleted the add-auto-plan-to-advanced-trip-form branch October 31, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants