Extract journey request from RouteRequest #4446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: bartosz <[email protected]> Co-authored-by: Thomas Gran <[email protected]> Co-authored-by: Hannes Junnila <[email protected]>
Co-authored-by: bartosz <[email protected]> Co-authored-by: Thomas Gran <[email protected]> Co-authored-by: Hannes Junnila <[email protected]>
…d VehicleRentalRequest
hannesj
force-pushed
the
otp2_journey_request
branch
from
01b7dd1
to
efda68f
Compare
t2gran
previously approved these changes
Sep 14, 2022
hannesj
force-pushed
the
otp2_journey_request
branch
from
249b020
to
56b8200
Compare
Bartosz-Kruba
previously approved these changes
Sep 14, 2022
Codecov ReportBase: 58.43% // Head: 58.49% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4446 +/- ##
=============================================
+ Coverage 58.43% 58.49% +0.05%
- Complexity 11386 11425 +39
=============================================
Files 1501 1508 +7
Lines 59814 59954 +140
Branches 6832 6831 -1
=============================================
+ Hits 34954 35068 +114
- Misses 22792 22827 +35
+ Partials 2068 2059 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
t2gran
approved these changes
Sep 15, 2022
|
I merged this with one approval, since we had two approvals before @hannesj merged the dev-2.x into this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a refactor of the RoutingRequest
Issue
Contiues from #4426
closes #4156