Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move intersectionTraversalCostModel into StreetPreferences #4444

Merged

Conversation

hannesj
Copy link
Contributor

@hannesj hannesj commented Sep 12, 2022

Summary

In #4419, we cnaged the configuration of the IntersectionTraversalCostModel to be read from the osmDefaults object in build-config.json. However if we configure the OpenStreetMap feeds explicitly, we need to also remember to set the osmDefaults, only for this configuration. As this is only used in runtime, it is easier to split it up form the tag mapping, into its own configuration property.

Also, we want to remove the router context (done in #4432), so I moved this property from the graph to the StreetProperties, so it can eg. be set based on the origin/destination locations later on

@hannesj hannesj added this to the 2.2 milestone Sep 12, 2022
@hannesj hannesj requested a review from a team as a code owner September 12, 2022 09:49
@hannesj hannesj added the bump serialization id Add this label if you want the serialization id automatically bumped after merging the PR label Sep 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4444 (d71324f) into dev-2.x (f2e6acd) will increase coverage by 0.28%.
The diff coverage is 75.09%.

@@              Coverage Diff              @@
##             dev-2.x    #4444      +/-   ##
=============================================
+ Coverage      58.22%   58.51%   +0.28%     
- Complexity     11219    11417     +198     
=============================================
  Files           1482     1497      +15     
  Lines          59262    59769     +507     
  Branches        6786     6794       +8     
=============================================
+ Hits           34508    34972     +464     
- Misses         22696    22743      +47     
+ Partials        2058     2054       -4     
Impacted Files Coverage Δ
...ataoverlay/DataOverlayStreetEdgeCostExtension.java 0.00% <0.00%> (ø)
...qlapi/datafetchers/LegacyGraphQLQueryTypeImpl.java 6.25% <0.00%> (-0.02%) ⬇️
...entripplanner/ext/transmodelapi/TransmodelAPI.java 0.00% <ø> (ø)
...er/ext/transmodelapi/TransmodelGraphQLPlanner.java 0.00% <0.00%> (ø)
...tripplanner/ext/traveltime/TravelTimeResource.java 0.00% <0.00%> (ø)
.../opentripplanner/ext/traveltime/spt/SPTWalker.java 0.00% <0.00%> (ø)
...rg/opentripplanner/api/common/RoutingResource.java 0.00% <0.00%> (ø)
...va/org/opentripplanner/api/model/ApiItinerary.java 100.00% <ø> (ø)
.../opentripplanner/api/resource/PlannerResource.java 0.00% <0.00%> (ø)
..._builder/module/configure/GraphBuilderModules.java 0.00% <0.00%> (ø)
... and 122 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hannesj hannesj force-pushed the otp2_move_intersection_cost_model branch from 7e2d1fa to e6b806a Compare September 13, 2022 17:38
@hannesj hannesj merged commit 4d4ef9d into opentripplanner:dev-2.x Sep 16, 2022
@hannesj hannesj deleted the otp2_move_intersection_cost_model branch September 16, 2022 07:44
t2gran pushed a commit that referenced this pull request Sep 16, 2022
t2gran pushed a commit that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump serialization id Add this label if you want the serialization id automatically bumped after merging the PR Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants