-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move intersectionTraversalCostModel into StreetPreferences #4444
Merged
hannesj
merged 7 commits into
opentripplanner:dev-2.x
from
entur:otp2_move_intersection_cost_model
Sep 16, 2022
Merged
Move intersectionTraversalCostModel into StreetPreferences #4444
hannesj
merged 7 commits into
opentripplanner:dev-2.x
from
entur:otp2_move_intersection_cost_model
Sep 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesj
added
the
bump serialization id
Add this label if you want the serialization id automatically bumped after merging the PR
label
Sep 12, 2022
Codecov Report
@@ Coverage Diff @@
## dev-2.x #4444 +/- ##
=============================================
+ Coverage 58.22% 58.51% +0.28%
- Complexity 11219 11417 +198
=============================================
Files 1482 1497 +15
Lines 59262 59769 +507
Branches 6786 6794 +8
=============================================
+ Hits 34508 34972 +464
- Misses 22696 22743 +47
+ Partials 2058 2054 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hannesj
force-pushed
the
otp2_move_intersection_cost_model
branch
from
September 12, 2022 10:02
d71324f
to
cf39ad8
Compare
hannesj
force-pushed
the
otp2_move_intersection_cost_model
branch
from
September 13, 2022 14:11
cf39ad8
to
7e2d1fa
Compare
hannesj
force-pushed
the
otp2_move_intersection_cost_model
branch
from
September 13, 2022 17:38
7e2d1fa
to
e6b806a
Compare
t2gran
reviewed
Sep 14, 2022
src/main/java/org/opentripplanner/standalone/config/RoutingRequestMapper.java
Outdated
Show resolved
Hide resolved
…and DrivingDirection
t2gran
approved these changes
Sep 15, 2022
Bartosz-Kruba
approved these changes
Sep 16, 2022
t2gran
pushed a commit
that referenced
this pull request
Sep 16, 2022
t2gran
pushed a commit
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump serialization id
Add this label if you want the serialization id automatically bumped after merging the PR
Technical Debt
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #4419, we cnaged the configuration of the
IntersectionTraversalCostModel
to be read from theosmDefaults
object inbuild-config.json
. However if we configure the OpenStreetMap feeds explicitly, we need to also remember to set theosmDefaults
, only for this configuration. As this is only used in runtime, it is easier to split it up form the tag mapping, into its own configuration property.Also, we want to remove the router context (done in #4432), so I moved this property from the graph to the StreetProperties, so it can eg. be set based on the origin/destination locations later on