Extract LegMode from TraverseMode

[hannesj]

Summary

Currently TraverseMode is used in the mode for a Leg. Extract a separate enum, which is used for otput, so that we can simplify the TraverseMode and make it completely internal to the a* classes.

[hannesj]

I reviewed the commits from @t2gran. Looks good for me

[codecov-commenter]

Codecov Report

Base: 58.43% // Head: 58.43% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (119f34a) compared to base (aff0726).
Patch coverage: 43.63% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff             @@
##             dev-2.x    #4443    +/-   ##
===========================================
  Coverage      58.43%   58.43%            
+ Complexity     11425    11386    -39     
===========================================
  Files           1500     1501     +1     
  Lines          59913    59813   -100     
  Branches        6821     6832    +11     
===========================================
- Hits           35011    34954    -57     
+ Misses         22840    22790    -50     
- Partials        2062     2069     +7     

Impacted Files	Coverage Δ
...tripplanner/ext/fares/impl/NycFareServiceImpl.java	0.00% <0.00%> (ø)
...ipplanner/ext/fares/impl/SFBayFareServiceImpl.java	0.00% <0.00%> (ø)
...a/org/opentripplanner/api/mapping/RouteMapper.java	0.00% <0.00%> (ø)
...a/org/opentripplanner/api/model/ApiRouterInfo.java	0.00% <0.00%> (ø)
...agger/RemoveBikerentalWithMostlyWalkingFilter.java	82.35% <0.00%> (ø)
...ntripplanner/routing/api/request/RouteRequest.java	72.83% <ø> (-0.31%)	⬇️
.../opentripplanner/routing/impl/GraphPathFinder.java	70.45% <ø> (+3.06%)	⬆️
...ner/transit/raptor/api/path/PathStringBuilder.java	100.00% <ø> (ø)
...rg/opentripplanner/visualizer/GraphVisualizer.java	0.00% <0.00%> (ø)
...java/org/opentripplanner/visualizer/ShowGraph.java	0.00% <ø> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.