Add timeZone parameter to hsl and parkapi vehicle parking updaters #4427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesj
previously approved these changes
Sep 2, 2022
hannesj
requested review from
vpaturet and
leonardehrenfried
and removed request for
vpaturet
leonardehrenfried
previously approved these changes
Sep 2, 2022
|
It's the same as for OSM parks. Null opening hours will be created. Is that ok? |
|
Actually now that I think about it, what I said is probably not true for HSL park. I think I'll add one more commit to fix it. |
Yes, that's fine. |
optionsome
dismissed stale reviews from leonardehrenfried and hannesj
via
f851590
leonardehrenfried
approved these changes
Sep 2, 2022
hannesj
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
timeZoneparameter to HSL and parkapi updaters to determine the time zone for the opening hours.Issue
fixes #4428
Unit tests
Updated tests.
Documentation
Updated sandbox documentation.
Changelog
Added for sandbox