Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Document why unused parameters in Raptor API should NOT be deleted. #4413

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

t2gran
Copy link
Member

@t2gran t2gran commented Aug 25, 2022

Summary

Small code doc change to Raptor.

Issue

Related to #4410

Unit tests

Not relevant

Documentation

@t2gran t2gran added this to the 2.2 milestone Aug 25, 2022
@t2gran t2gran requested a review from a team as a code owner August 25, 2022 12:20
@codecov-commenter
Copy link

Codecov Report

Merging #4413 (ee919be) into dev-2.x (f791309) will increase coverage by 0.05%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             dev-2.x    #4413      +/-   ##
=============================================
+ Coverage      58.04%   58.09%   +0.05%     
- Complexity     11045    11067      +22     
=============================================
  Files           1454     1455       +1     
  Lines          58725    58748      +23     
  Branches        6760     6765       +5     
=============================================
+ Hits           34085    34129      +44     
+ Misses         22605    22581      -24     
- Partials        2035     2038       +3     
Impacted Files Coverage Δ
...oradapter/transit/request/TripPatternForDates.java 75.71% <0.00%> (-1.90%) ⬇️
.../algorithm/raptoradapter/router/TransitRouter.java 75.89% <0.00%> (-0.22%) ⬇️
...tripplanner/ext/traveltime/TravelTimeResource.java 0.00% <0.00%> (ø)
.../transit/raptor/api/transit/RaptorTripPattern.java 100.00% <0.00%> (ø)
...rithm/raptoradapter/transit/cost/McCostParams.java 61.90% <0.00%> (ø)
...aptoradapter/transit/cost/McCostParamsBuilder.java 100.00% <0.00%> (ø)
...dapter/transit/frequency/FrequencyAlightEvent.java 0.00% <0.00%> (ø)
...pter/transit/frequency/FrequencyBoardingEvent.java 0.00% <0.00%> (ø)
...er/transit/frequency/TripFrequencyBoardSearch.java 0.00% <0.00%> (ø)
...r/transit/frequency/TripFrequencyAlightSearch.java 0.00% <0.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hannesj hannesj merged commit 2274e2b into opentripplanner:dev-2.x Aug 25, 2022
@hannesj hannesj deleted the otp2_raptor_api_clean_code branch August 25, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants