Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not crash if PageCursorFactory can't be created #4397

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

hannesj
Copy link
Contributor

@hannesj hannesj commented Aug 22, 2022

Summary

This happens eg. when forward search fails, and no search window/earliest departure time can be set.

Issue

Related to #4396

@hannesj hannesj added this to the 2.2 milestone Aug 22, 2022
@hannesj hannesj requested a review from t2gran August 22, 2022 11:15
@hannesj hannesj requested a review from a team as a code owner August 22, 2022 11:15
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Merging #4397 (c2f328c) into dev-2.x (0722e64) will increase coverage by 0.01%.
The diff coverage is 50.00%.

@@              Coverage Diff              @@
##             dev-2.x    #4397      +/-   ##
=============================================
+ Coverage      58.02%   58.04%   +0.01%     
- Complexity     11034    11048      +14     
=============================================
  Files           1454     1454              
  Lines          58704    58727      +23     
  Branches        6751     6760       +9     
=============================================
+ Hits           34063    34088      +25     
+ Misses         22611    22607       -4     
- Partials        2030     2032       +2     
Impacted Files Coverage Δ
...uting/algorithm/mapping/RoutingResponseMapper.java 68.75% <0.00%> (-2.99%) ⬇️
.../opentripplanner/transit/model/timetable/Trip.java 93.54% <100.00%> (+0.32%) ⬆️
...quest/RoutingRequestTransitDataProviderFilter.java 90.00% <0.00%> (-2.50%) ⬇️
...ithm/raptoradapter/transit/TripPatternForDate.java 78.46% <0.00%> (-0.58%) ⬇️
...oradapter/transit/request/TripPatternForDates.java 77.61% <0.00%> (-0.33%) ⬇️
.../algorithm/raptoradapter/transit/TransitLayer.java 80.00% <0.00%> (ø)
...ansit/request/RaptorRoutingRequestTransitData.java 89.79% <0.00%> (ø)
.../opentripplanner/transit/raptor/util/IntUtils.java
...n/java/org/opentripplanner/util/lang/IntUtils.java 23.07% <0.00%> (ø)
...it/constrainedtransfer/TransferIndexGenerator.java 90.97% <0.00%> (+0.32%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hannesj hannesj added the Entur Test This is currently being tested at Entur label Aug 24, 2022
@hannesj hannesj merged commit d64ae0c into opentripplanner:dev-2.x Aug 25, 2022
@hannesj hannesj deleted the otp2_fix_invalid_mapper branch August 25, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Entur Test This is currently being tested at Entur Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants