Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Revert "Add tag for service" #135

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Conversation

tylerbenson
Copy link
Contributor

Per discussion on #131.

Reverts #119

We can add a better replacement in a separate PR, but I wanted to get this removed before it gets too wide spread.

@tylerbenson tylerbenson force-pushed the revert-119-tyler/service-tag branch from 4d8db95 to d7896c8 Compare December 6, 2018 00:10
@austinlparker austinlparker self-requested a review December 20, 2018 18:55
Copy link
Member

@austinlparker austinlparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per #131 this lgtm

@tylerbenson
Copy link
Contributor Author

I think we've gotten the feedback we needed. Merging to avoid further confusion.

@tylerbenson tylerbenson merged commit b9fdcdd into master Jan 3, 2019
@tylerbenson tylerbenson deleted the revert-119-tyler/service-tag branch January 3, 2019 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants