Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outreachy - added initial ideas #224

Merged
merged 1 commit into from
Oct 4, 2017

Conversation

jpkrohling
Copy link
Contributor

Signed-off-by: Juraci Paixão Kröhling [email protected]

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@pritianka-zz
Copy link
Collaborator

All looks good! I haven't had the time to grammar check yet but if you've done a spell-check etc, can merge since I know this is urgent.

@jpkrohling
Copy link
Contributor Author

jpkrohling commented Oct 4, 2017

@objectiser , could you proofread this one?

@reimertz
Copy link
Collaborator

reimertz commented Oct 4, 2017

@jpkrohling LGTM and great work! Just give me an 👍 and I'll merge it.

* Documentation + examples
* The end result would be: a trace starts when a user opens the app on the phone and backend microservices are called

### Split the JavaScript OT library: NodeJS and Browser
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a jaeger specific task I believe @pavolloffay ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it is!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add Jaeger in the title

### Drive consensus on a common format for reporting trace/span data

Mentor: Gary Brown

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to reference this opentracing/specification#86 - although it discusses both in-band and out-of-band, but it sets the context aswell.

Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good .

@reimertz reimertz merged commit d8f4ea4 into opentracing:master Oct 4, 2017
* HttpSender which works in a web browser
* Intercept web browser events (maybe can be done as OpenTracing instrumentation)

### Drive consensus on a common format for reporting trace/span data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this is a good intern project, it requires a lot more experience with the tracing space

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reason I thought this might be good is that the intern project is just to document and implement prototype (one or more language tracers/jaeger backend adapter) - guidance on what should be in the standard format should come from the community, so their role would be to request input and feed that into their prototype. The initial starting point would be that it must capture the information provided via the OpenTracing API.
@bhs Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we keep this, could you send a PR to change this page with the outcome of the discussion?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually "driving consensus" is a tall order for an intern... lots of strong and entrenched opinions in this area, etc, etc. I would suggest reframing this as "Document the feasibility or infeasibility of candidate format standards for trace/span data" or something similar. That would, in fact, help to drive consensus but removes the sticky parts that are probably out of scope for an intern. My two cents.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yurishkuro Would rewording as @bhs suggests be ok, or would you still prefer it is removed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Can we add some description?

@@ -54,8 +57,56 @@ Interested in becoming a mentor? Contact one of the coordinators!

## Available tasks

Coming soon. At this moment, we recommend looking at the following issue trackers for smaller tasks that might
give a sense of what's coming:
### Instrumentation for mobile applications
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing mobile instrumentation efficiently is actually a non-trivial engineering project. For example, our mobile team has a whole platform sub-team that built a performance SDK that does clever things like gauging the available network bandwidth from the phone and sending monitoring data via unused bandwidth only.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that to provide a production quality solution will be non-trivial, but this type of project has been popular with GSoC students on Hawkular, and the expectation would only be to provide an initial proof of concept with demonstrator. If it then looks promising, further performance work could be done by more experienced contributors?

Mentor: Gary Brown

* C#
* Kotlin for Android
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is funny there is no OpenTracing Kotlin API

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that Kotlin is a JVM-based language, so, the Java one would work. I'm not sure Kotlin would make sense here, but it's part of the task to figure this out.

@pavolloffay
Copy link
Member

A good task might be to write a test suite that validates tracer implementation.

@jpkrohling
Copy link
Contributor Author

jpkrohling commented Oct 5, 2017

A good task might be to write a test suite that validates tracer implementation.

You mean, like a test harness for OpenTracing tracer implementations?

@pavolloffay
Copy link
Member

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants