This repository has been archived by the owner on May 23, 2023. It is now read-only.
Clarify that Tracer.extract can return null #203
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #168 in practice the tracer implementations return null when
SpanContext
is not found in the carrier. This change documents this behaviour.It also adds a dependency on
com.google.code.findbugs:jsr305
but it's optional, it is not listed in the pom and client applications do not need to depend on jsr305.Compiling the code above with:
procudes no warnings.