Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves XML docs (typos, wrong code samples, inconsistent naming, refs) #74

Merged
merged 1 commit into from
Mar 7, 2018

Conversation

cwe1ss
Copy link
Member

@cwe1ss cwe1ss commented Mar 2, 2018

This PR only touches XML docs. It fixes typos, wrong code samples, inconsistent naming (e.g. Span vs span), missing punctuation and adds xml references where possible.

I'll merge this on Tuesday if there's no objections.

@cwe1ss cwe1ss added this to the 0.12.0 milestone Mar 2, 2018
Copy link
Contributor

@ndrwrbgs ndrwrbgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major (intent changing or breaking) here, so LGTM!

@cwe1ss cwe1ss merged commit 961d255 into master Mar 7, 2018
@cwe1ss cwe1ss deleted the cweiss/xmldocs branch March 7, 2018 08:14
@cwe1ss cwe1ss mentioned this pull request Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants