Converting TextMapReader callback to functor (#2)

* Update tracer.h * Update tracer.cc * Update tracer.h * Update tracer.h * Update opentracing.t.cc
opentracing · Dec 3, 2016 · e0ea9eb · e0ea9eb
1 parent 8b1efd1
commit e0ea9eb
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 4 deletions.
diff --git a/opentracing/tracer.cc b/opentracing/tracer.cc
@@ -58,6 +58,10 @@ TextMapReader::~TextMapReader()
 {
 }
 
+TextMapReader::ReadCallback::~ReadCallback()
+{
+}
+
 namespace {
 
 class NoopSpan : public virtual Span

diff --git a/opentracing/tracer.h b/opentracing/tracer.h
@@ -245,14 +245,26 @@ class TextMapReader : public virtual Reader
     virtual ~TextMapReader();
 
     /**
-     * The type of callback which will be called for each key.
+     * Callback functor typically implemented from the tracer in order to retrieve
+     * key-value pairs from the `TextMapReader`.
      */
-    typedef void (*PairReadCallback)(const std::string& key, const std::string& value, bool isBaggage);
+    struct ReadCallback
+    {
+        /**
+         *  Destroys this ReadCallback.
+         */
+        virtual ~ReadCallback();
+
+        /**
+         *  Will be called for each key-value pair.
+         */
+        virtual void operator() (const std::string& key, const std::string& value, bool isBaggage) const = 0;
+    };
 
     /**
      * Reads from the carrier and calls the `callback()` for each key-value pair.
      */
-    virtual void forEachPair(const PairReadCallback & callback) const = 0;
+    virtual void forEachPair(const ReadCallback & callback) const = 0;
 };
 
 /**

diff --git a/test/opentracing.t.cc b/test/opentracing.t.cc
@@ -158,7 +158,7 @@ class MapTextAdapter : public TextMapWriter, public TextMapReader
         m_carrier.insert(typename T::value_type(key, std::make_pair(value, isBaggage)));
     }
 
-    virtual void forEachPair(const PairReadCallback & callback) const
+    virtual void forEachPair(const ReadCallback & callback) const
     {
         for (typename T::const_iterator i = m_carrier.begin(); i != m_carrier.end(); ++i)
         {
-Original file line number
+Diff line change
@@ Expand Up / @@ -58,6 +58,10 @@ TextMapReader::~TextMapReader() @@
     {
     }
+    TextMapReader::ReadCallback::~ReadCallback()
+    {
+    }
     namespace {
     class NoopSpan : public virtual Span
@@ Expand Down @@