Skip to content

Commit

Permalink
Run zipkin configuration before Noop tracer producer
Browse files Browse the repository at this point in the history
  • Loading branch information
geoand authored Jun 20, 2018
1 parent 6473ea3 commit 18d0e3b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
5 changes: 5 additions & 0 deletions opentracing-spring-zipkin-starter/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@
</properties>

<dependencies>
<dependency>
<groupId>io.opentracing.contrib</groupId>
<artifactId>opentracing-spring-tracer-configuration-starter</artifactId>
<version>${version.io.opentracing.contrib-opentracing-spring-tracer}</version>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-autoconfigure</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
@ConditionalOnClass(brave.opentracing.BraveTracer.class)
@ConditionalOnMissingBean(io.opentracing.Tracer.class)
@ConditionalOnProperty(value = "opentracing.zipkin.enabled", havingValue = "true", matchIfMissing = true)
@AutoConfigureBefore(name = "io.opentracing.contrib.spring.web.autoconfig.TracerAutoConfiguration")
@AutoConfigureBefore(io.opentracing.contrib.spring.tracer.configuration.TracerAutoConfiguration.class)
@EnableConfigurationProperties(ZipkinConfigurationProperties.class)
public class ZipkinAutoConfiguration {

Expand Down
1 change: 1 addition & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
<main.basedir>${project.basedir}</main.basedir>

<version.io.opentracing>0.31.0</version.io.opentracing>
<version.io.opentracing.contrib-opentracing-spring-tracer>0.1.0</version.io.opentracing.contrib-opentracing-spring-tracer>
<version.org.springframework.boot>1.5.12.RELEASE</version.org.springframework.boot>
<version.brave-opentracing>0.30.3</version.brave-opentracing>
<version.zipkin-sender-okhttp>2.6.0</version.zipkin-sender-okhttp>
Expand Down

0 comments on commit 18d0e3b

Please sign in to comment.