Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use "message_bus.destination" tag for both, producer and consumer #71

Merged
merged 2 commits into from
Jan 31, 2020
Merged

use "message_bus.destination" tag for both, producer and consumer #71

merged 2 commits into from
Jan 31, 2020

Conversation

zserge
Copy link
Contributor

@zserge zserge commented Jan 30, 2020 •
edited
Loading

Related to #70

@malafeev
Copy link
Contributor

@zserge looks like tests failed

@coveralls
Copy link

Pull Request Test Coverage Report for Build 226

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.423%
Totals Coverage Status
Change from base Build 224: 0.0%
Covered Lines: 273
Relevant Lines: 411
💛 - Coveralls

@zserge
Copy link
Contributor Author

zserge commented Jan 31, 2020

@malafeev Resolved. Edited the tests to use message_bus.destination tag as well.

@malafeev malafeev merged commit 7c67ce7 into opentracing-contrib:master Jan 31, 2020
@malafeev malafeev mentioned this pull request Jan 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zserge @malafeev @coveralls