Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making TracingClientInterceptor.Builder constructor private #47

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Making TracingClientInterceptor.Builder constructor private #47

merged 1 commit into from
Mar 5, 2020

Conversation

ravirajj
Copy link
Contributor

@ravirajj ravirajj commented Sep 17, 2019 •
edited
Loading

  • Builder constructor is private and should be accessed via the static TracingClientInterceptor.newBuilder() method.
  • Same as TracingServerInterceptor.newBuilder().

@coveralls
Copy link

Pull Request Test Coverage Report for Build 171

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.7%) to 97.018%
Files with Coverage Reduction New Missed Lines %
src/main/java/io/opentracing/contrib/grpc/TracingServerInterceptor.java 1 98.24%
src/main/java/io/opentracing/contrib/grpc/GrpcFields.java 2 82.35%
Totals Coverage Status
Change from base Build 170: -0.7%
Covered Lines: 423
Relevant Lines: 436
💛 - Coveralls

@malafeev
Copy link
Contributor

malafeev commented Sep 18, 2019 •
edited
Loading

@ravirajj please fix also README, I see several new TracingClientInterceptor.Builder(tracer)

This was referenced Oct 2, 2019
Closed
Merged
@eugeniyk
Copy link
Contributor

eugeniyk commented Mar 5, 2020

@malafeev looks like #50 is the README change you've asked

@malafeev malafeev merged commit e6f7911 into opentracing-contrib:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ravirajj @coveralls @malafeev @eugeniyk