Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to TracingClientInterceptor and TracingServerInterceptor #45

Merged
merged 2 commits into from
Sep 9, 2019

Conversation

ravirajj
Copy link
Contributor

@ravirajj ravirajj commented Sep 9, 2019

  • Rename ClientTracingInterceptor to TracingClientInterceptor.
  • Rename ServerTracingInterceptor to TracingServerInterceptor.

@coveralls
Copy link

coveralls commented Sep 9, 2019

Pull Request Test Coverage Report for Build 163

  • 28 of 28 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 95.862%

Totals Coverage Status
Change from base Build 159: 0.02%
Covered Lines: 417
Relevant Lines: 435

💛 - Coveralls

.travis.yml Outdated
@@ -3,6 +3,7 @@ dist: trusty

language: java
jdk:
- openjdk8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect it breaks release process because it's completely done by travis and now two streams will make a release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis supports testing against multiple JDKs: https://docs.travis-ci.com/user/languages/java#testing-against-multiple-jdks.

It passes build. Did you still want me to revert this?

Copy link
Contributor

@malafeev malafeev Sep 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build is passed, until release:prepare will be triggered
look at travis/publish.sh script:

# If we are on a release tag, the following will update any version references and push a version tag for deployment.
elif build_started_by_tag; then
  safe_checkout_master
  ./mvnw --batch-mode -s ./.settings.xml -Prelease -nsu -DreleaseVersion="$(release_version)" -Darguments="-DskipTests" release:prepare
fi
# If the deployment succeeded, sync it to Maven Central. Note: this needs to be done once per project, not module, hence -N
  if is_release_commit; then
    ./mvnw --batch-mode -s ./.settings.xml -nsu -N io.zipkin.centralsync-maven-plugin:centralsync-maven-plugin:sync
  fi

It needs to be reverted or fixed to run only on oraclejdk8

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@malafeev malafeev merged commit 8a6fe4c into opentracing-contrib:master Sep 9, 2019
@ravirajj ravirajj deleted the rj.interceptors branch September 9, 2019 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants