-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename to TracingClientInterceptor and TracingServerInterceptor #45
Conversation
Pull Request Test Coverage Report for Build 163
💛 - Coveralls |
.travis.yml
Outdated
@@ -3,6 +3,7 @@ dist: trusty | |||
|
|||
language: java | |||
jdk: | |||
- openjdk8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expect it breaks release process because it's completely done by travis and now two streams will make a release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis supports testing against multiple JDKs: https://docs.travis-ci.com/user/languages/java#testing-against-multiple-jdks.
It passes build. Did you still want me to revert this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build is passed, until release:prepare
will be triggered
look at travis/publish.sh
script:
# If we are on a release tag, the following will update any version references and push a version tag for deployment.
elif build_started_by_tag; then
safe_checkout_master
./mvnw --batch-mode -s ./.settings.xml -Prelease -nsu -DreleaseVersion="$(release_version)" -Darguments="-DskipTests" release:prepare
fi
# If the deployment succeeded, sync it to Maven Central. Note: this needs to be done once per project, not module, hence -N
if is_release_commit; then
./mvnw --batch-mode -s ./.settings.xml -nsu -N io.zipkin.centralsync-maven-plugin:centralsync-maven-plugin:sync
fi
It needs to be reverted or fixed to run only on oraclejdk8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
78c45cf
to
6228c8c
Compare
ClientTracingInterceptor
toTracingClientInterceptor
.ServerTracingInterceptor
toTracingServerInterceptor
.