Changing minsdk from 22 to 21 #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that Bluetrace/Opentrace has the minsdk set at 22 although when changed to 21, it seems to compile and run on the Android emulator running Android 5.0 successfully, admittedly I personally haven't got past the sign up screen as I haven't connected it to a Firebase instance.
I am aware of the limitations of the GATT implementation with the use 512 byte MTU payloads and that potentially not working well with older bluetooth controllers. The @covidsafewatch community is looking to test it but hasn't had the time.
In the testing methodologies repository, the oldest Android device tested was the Nexus 5X which was launched with Android 6.0 (API Level 23). There doesn't seem to be an public knowledge of Android 5.1 being tested.
I was wondering if either this pull request could be merged or if you could give insight as to why the minsdk is set at 22.
In no particular order, I'd like to give a very special thanks to:
They have done an amazing job helping me out 🙂