Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor admonition component #106

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Refactor admonition component #106

merged 3 commits into from
Sep 18, 2023

Conversation

damianstasik
Copy link
Collaborator

@damianstasik damianstasik commented Sep 18, 2023

This PR replaces the built-in admonition component. It also removes max-width from docs content (Tailwind's prose), not needed as we have container that does that.

Before:

Light Dark
Screenshot 2023-09-18 at 14 39 08 Screenshot 2023-09-18 at 14 38 53

After:

Light Dark
Screenshot 2023-09-18 at 14 37 54 Screenshot 2023-09-18 at 14 38 07

@damianstasik
Copy link
Collaborator Author

Closes #103

@Roma36
Copy link
Collaborator

Roma36 commented Sep 18, 2023

@damianstasik looks awesome, but I'd keep the original color for warning in dark mode. But it's just my taste.

@damianstasik
Copy link
Collaborator Author

damianstasik commented Sep 18, 2023

@Roma36 as you can see I'm using the orange instead of the yellow as we use it for branding (and it looks bad for admonitions). I was thinking we could rename our yellow to brand and use tailwind's yellow for these admonitions. I just didn't want to introduce any noise.

WDYT?

@Roma36
Copy link
Collaborator

Roma36 commented Sep 18, 2023

@damianstasik I like the approach you propose with introducing brand yellow.

@damianstasik
Copy link
Collaborator Author

@Roma36 here's how it would look like, wdyt?

Dark Light
Screenshot 2023-09-18 at 15 16 09 Screenshot 2023-09-18 at 15 16 32

@Roma36
Copy link
Collaborator

Roma36 commented Sep 18, 2023

@damianstasik I like that "warning" looks not so "dangerous" now

@damianstasik
Copy link
Collaborator Author

@Roma36 pushed renaming and the actual color change as separate commits, if everything's okay, let's merge it 🚢

@Roma36 Roma36 merged commit fb69400 into main Sep 18, 2023
1 check passed
@damianstasik damianstasik deleted the refactor-admonition branch September 19, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants