-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor admonition component #106
Conversation
Closes #103 |
@damianstasik looks awesome, but I'd keep the original color for warning in dark mode. But it's just my taste. |
@Roma36 as you can see I'm using the orange instead of the yellow as we use it for branding (and it looks bad for admonitions). I was thinking we could rename our yellow to WDYT? |
@damianstasik I like the approach you propose with introducing brand yellow. |
@Roma36 here's how it would look like, wdyt?
|
@damianstasik I like that "warning" looks not so "dangerous" now |
@Roma36 pushed renaming and the actual color change as separate commits, if everything's okay, let's merge it 🚢 |
This PR replaces the built-in admonition component. It also removes
max-width
from docs content (Tailwind's prose), not needed as we have container that does that.Before:
After: