Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable BORDER_ROUTING #20

Closed
wants to merge 1 commit into from

Conversation

edmont
Copy link
Member

@edmont edmont commented Jan 4, 2022

Build certification reference border router with BORDER_ROUTING enabled. This is required for MATN-TC-02 for TD roles.

Build certification reference border router with BORDER_ROUTING
enabled. This is required for MATN-TC-02 for TD roles.
@edmont
Copy link
Member Author

edmont commented Jan 4, 2022

See discussion in openthread/openthread#7175

@simonlingoogle
Copy link
Member

simonlingoogle commented Jan 4, 2022

I doubt if we need BORDER ROUTING for Thead 1.2 certification reference BR.
Seems too much complexity added.

Changing Echo mode to OT_ICMP6_ECHO_HANDLER_ALL should suffice for reference BRs?

@edmont
Copy link
Member Author

edmont commented Jan 4, 2022

I don't think OT_ICMP6_ECHO_HANDLER_ALL is the best solution for final products (actually it can't be currently configured) so my approach is to build the reference device as similar as possible as the final product. Your concern is just a matter of reference device resources?

@simonlingoogle
Copy link
Member

I don't think OT_ICMP6_ECHO_HANDLER_ALL is the best solution for final products (actually it can't be currently configured) so my approach is to build the reference device as similar as possible as the final product. Your concern is just a matter of reference device resources?

BORDER_ROUTING adds too much logic to the reference devices? For example, BORDER_ROUTING will automatically add OMR prefix to the Network Data. BORDER_ROUTING will also automatically add external routes to Network Data for any prefixes it discovered from the Backbone link. I am concerned these behavior may interference with the normal certification process.

It's better to keep the reference device's behavior as simple as possible.

Thoughts?

@edmont
Copy link
Member Author

edmont commented Jan 5, 2022

I agree it adds extra complexity, my main point is this complexity may uncover Thread Harness issues that would occur when using regular Thread devices built with BORDER_ROUTING support as DUT. But okay, lets address those when the time comes.

Please check openthread/openthread#7288

@edmont edmont closed this Jan 5, 2022
@edmont edmont deleted the pr/enable-border-routing branch January 14, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants