[api] enable DIAG_RST notify funcation into commissioner #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds DIAG_RST notify command into the commissioner module, allowing users to reset MacCounters(9) TLV from a peer Thread device by settting the device's mesh local address and TLV mask bits flag.
Test:
>> config set pskc 445f2b5ca6f2a93a55ce570a70efeecb
[done]
>> start 192.168.9.2 49154
[done]
> netdiag reset maccounters
[done]
>> netdiag query maccounters
Peer Address: fda1:7966:fc90:d97:0:ff:fe00:bc00
Content: {
"MacCounters": "{\n \"IfInBroadcastPkts\": 0,\n \"IfInDiscards\": 0,\n \"IfInErrors\": 0,\n \"IfInUcastPkts\": 0,\n \"IfInUnknownProtos\": 0,\n \"IfOutBroadcastPkts\": 2,\n \"IfOutDiscards\": 0,\n \"IfOutErrors\": 0,\n \"IfOutUcastPkts\": 0\n}"
}
[done]
wgtdkp
approved these changes
Nov 27, 2024
Co-authored-by: Kangping <[email protected]>
Co-authored-by: Kangping <[email protected]>
|
@jwhui Could you please take a look at my code? I would be very grateful for your feedback. |
jwhui
reviewed
Nov 27, 2024
Co-authored-by: Jonathan Hui <[email protected]>
Co-authored-by: Jonathan Hui <[email protected]>
Co-authored-by: Jonathan Hui <[email protected]>
Co-authored-by: Jonathan Hui <[email protected]>
Co-authored-by: Jonathan Hui <[email protected]>
|
@jwhui Could you please review this PR again for me? Thanks~~ |
jwhui
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds DIAG_RST notify command into the commissioner module, allowing users to reset MacCounters(9) TLV from a peer Thread device by settting the device's mesh local address and TLV mask bits flag.
Test: