[cli] fix signal handling #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
==========================================
+ Coverage 64.77% 64.82% +0.05%
==========================================
Files 52 52
Lines 4749 4754 +5
==========================================
+ Hits 3076 3082 +6
+ Misses 1673 1672 -1
|
simonlingoogle
approved these changes
Jul 27, 2020
simonlingoogle
approved these changes
Jul 27, 2020
jwhui
approved these changes
Jul 27, 2020
|
@wgtdkp , please help resolve conflicts. |
# Conflicts: resolve conflicts
|
@jwhui done. |
bukepo
reviewed
Jul 28, 2020
bukepo
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronization primitives (std::mutex, std::future) in namespace
stdare used to synchronize calls to the commissioner API. Unfortunately, those synchronization primitives are not signal-safe and will result in deadlock.This PR fixes this by using a dedicated thread to wait for the signal.