Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[posix] set addr gen mode to none on linux #2419

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

Irving-cl
Copy link
Contributor

This PR sets the addr gen mode of wpan interface to NONE on linux.

This PR depends on #2410. #2410 needs to be merged first.

@Irving-cl Irving-cl force-pushed the posix_netif_wpan_addr_gen_mode branch from 3e63d05 to f9b4316 Compare August 6, 2024 11:48
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 75.80645% with 15 lines in your changes missing coverage. Please review.

Project coverage is 45.29%. Comparing base (2b41187) to head (056e46c).
Report is 748 commits behind head on main.

Files Patch % Lines
src/ncp/posix/netif_linux.cpp 80.43% 6 Missing and 3 partials ⚠️
src/ncp/posix/netif.cpp 57.14% 3 Missing ⚠️
tests/gtest/test_netif.cpp 66.66% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2419       +/-   ##
===========================================
- Coverage   55.77%   45.29%   -10.49%     
===========================================
  Files          87       99       +12     
  Lines        6890    11171     +4281     
  Branches        0      805      +805     
===========================================
+ Hits         3843     5060     +1217     
- Misses       3047     5863     +2816     
- Partials        0      248      +248     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Irving-cl Irving-cl mentioned this pull request Aug 6, 2024
17 tasks
@Irving-cl Irving-cl force-pushed the posix_netif_wpan_addr_gen_mode branch from f9b4316 to bafa257 Compare August 7, 2024 03:35
@Irving-cl Irving-cl requested a review from bukepo August 7, 2024 03:36
@Irving-cl Irving-cl marked this pull request as ready for review August 7, 2024 03:37
src/ncp/posix/netif_linux.cpp Outdated Show resolved Hide resolved
@Irving-cl Irving-cl force-pushed the posix_netif_wpan_addr_gen_mode branch from bafa257 to 6fe9c37 Compare August 8, 2024 09:53
@Irving-cl Irving-cl force-pushed the posix_netif_wpan_addr_gen_mode branch from 6fe9c37 to 056e46c Compare August 8, 2024 09:54
@Irving-cl Irving-cl requested review from abtink and jwhui August 8, 2024 09:57
Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wgtdkp
Copy link
Member

wgtdkp commented Aug 13, 2024

This kind of netlink messages requires specially NET_ADMIN CAPS I think, ot-daemon on Android doesn't have those CAPS so those configurations are delegated to Android system_server. You probably want to enable this in ot-br-posix for non-Android linux devices.

(You can try your code in Android see what error it will be like :)

@Irving-cl
Copy link
Contributor Author

(You can try your code in Android see what error it will be like

Thanks! As discussed, let's add a macro for the entire netif module and not enable it on Android. On Android, we will use the specific implementation for netif. I'll add a seperate PR for it.

@jwhui jwhui merged commit f93a3b8 into openthread:main Aug 13, 2024
32 checks passed
@Irving-cl Irving-cl deleted the posix_netif_wpan_addr_gen_mode branch August 13, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants