[dbus] add absl support for higher version protobuf #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch fixed below build error when the system/SDK using higher version of protobuf: |
TE-N-ElvenWang
force-pushed
the
protobuf_absl_support
branch
6 times, most recently
from
406be9a to
b064c14
Compare
TE-N-ElvenWang
force-pushed
the
protobuf_absl_support
branch
2 times, most recently
from
ead2c64 to
809971e
Compare
TE-N-ElvenWang
force-pushed
the
protobuf_absl_support
branch
from
809971e to
c12b179
Compare
|
@jwhui Could you please help on this? Since there don't have any reviewer added. |
bukepo
reviewed
Jan 25, 2024
src/proto/CMakeLists.txt
Outdated
Comment on lines
10
to
11
| if ("${Protobuf_VERSION}" MATCHES [[[0-9]+.([0-9]+).[0-9]+]]) | ||
| if(CMAKE_MATCH_1 GREATER_EQUAL 22) |
There was a problem hiding this comment.
Is it possible to use built-in VERSION_LESS?
Suggested change
| if ("${Protobuf_VERSION}" MATCHES [[[0-9]+.([0-9]+).[0-9]+]]) | |
| if(CMAKE_MATCH_1 GREATER_EQUAL 22) | |
| if (NOT "${Protobuf_VERSION}" VERSION_LESS 22) |
There was a problem hiding this comment.
@bukepo Thank you for your suggestion. Use built-in "VERSION_LESS" to check the version of protobuf. Please see the updated change.
TE-N-ElvenWang
force-pushed
the
protobuf_absl_support
branch
from
c12b179 to
d935c1e
Compare
bukepo
reviewed
Jan 26, 2024
|
Hi @bukepo , could you please give a look at the comments reply in this PR? Thanks! |
TE-N-ElvenWang
force-pushed
the
protobuf_absl_support
branch
from
b9b9787 to
a08f1ba
Compare
morningboata
approved these changes
Jan 31, 2024
Protobuf which higher than 22 need link absl. Add the linked shared library to pass the build. Signed-off-by: Haoran Wang <[email protected]>
TE-N-ElvenWang
force-pushed
the
protobuf_absl_support
branch
from
a08f1ba to
1c1ea4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobuf which higher than 22 need link absl. Add the linked shared library to pass the build.