Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[github-actions] upload core dump, so libs and binaries for crashed programs #5861

Merged
merged 4 commits into from
Dec 2, 2020

Conversation

Irving-cl
Copy link
Contributor

@Irving-cl Irving-cl commented Nov 25, 2020

This PR adds action to upload core dumps, so libs and binaries for 1.2 certification. This is intended to solve issues like #5802, #5774 where programs intermittently crash however hard to reproduce it. Related issue: #5805.

I added this for thread-1-2 and low-power-packet-verification first as an experimental work. We can add same actions for other items when it's necessary.

I've verified that we can analyze the core dumps with the artifacts using gdb successfully on our local PC: #5812 (comment)

@size-report
Copy link

size-report bot commented Nov 25, 2020

Size Report of OpenThread

Merging #5861 into master(d24833f).

name branch text data bss total
ot-cli-ftd_1.1 master 394872 768 51196 446836
#5861 394872 768 51196 446836
+/- 0 0 0 0
ot-cli-mtd_1.1 master 321016 768 42580 364364
#5861 321016 768 42580 364364
+/- 0 0 0 0
ot-ncp-ftd_1.1 master 388880 768 50476 440124
#5861 388880 768 50476 440124
+/- 0 0 0 0
ot-ncp-mtd_1.1 master 318080 768 41860 360708
#5861 318080 768 41860 360708
+/- 0 0 0 0
ot-rcp_1.1 master 64432 668 7656 72756
#5861 64432 668 7656 72756
+/- 0 0 0 0
libopenthread-cli-ftd.a_1.1 master 38267 0 3108 41375
#5861 38267 0 3108 41375
+/- 0 0 0 0
libopenthread-cli-mtd.a_1.1 master 30994 0 3108 34102
#5861 30994 0 3108 34102
+/- 0 0 0 0
libopenthread-ftd.a_1.1 master 190181 4 33344 223529
#5861 190181 4 33344 223529
+/- 0 0 0 0
libopenthread-mtd.a_1.1 master 130336 4 24728 155068
#5861 130336 4 24728 155068
+/- 0 0 0 0
libopenthread-ncp-ftd.a_1.1 master 48165 0 2388 50553
#5861 48165 0 2388 50553
+/- 0 0 0 0
libopenthread-ncp-mtd.a_1.1 master 43361 0 2388 45749
#5861 43361 0 2388 45749
+/- 0 0 0 0
libopenthread-rcp.a_1.1 master 27234 0 1532 28766
#5861 27234 0 1532 28766
+/- 0 0 0 0
libopenthread-radio.a_1.1 master 13537 0 150 13687
#5861 13537 0 150 13687
+/- 0 0 0 0
ot-cli-ftd_1.2 master 427856 768 61240 489864
#5861 427856 768 61240 489864
+/- 0 0 0 0
ot-cli-mtd_1.2 master 338048 768 43064 381880
#5861 338048 768 43064 381880
+/- 0 0 0 0
ot-ncp-ftd_1.2 master 416552 768 60520 477840
#5861 416552 768 60520 477840
+/- 0 0 0 0
ot-ncp-mtd_1.2 master 330728 768 42344 373840
#5861 330728 768 42344 373840
+/- 0 0 0 0
ot-rcp_1.2 master 71236 668 16528 88432
#5861 71236 668 16528 88432
+/- 0 0 0 0
libopenthread-cli-ftd.a_1.2 master 41448 0 3108 44556
#5861 41448 0 3108 44556
+/- 0 0 0 0
libopenthread-cli-mtd.a_1.2 master 33299 0 3108 36407
#5861 33299 0 3108 36407
+/- 0 0 0 0
libopenthread-ftd.a_1.2 master 218774 4 43288 262066
#5861 218774 4 43288 262066
+/- 0 0 0 0
libopenthread-mtd.a_1.2 master 143861 4 25112 168977
#5861 143861 4 25112 168977
+/- 0 0 0 0
libopenthread-ncp-ftd.a_1.2 master 48165 0 2388 50553
#5861 48165 0 2388 50553
+/- 0 0 0 0
libopenthread-ncp-mtd.a_1.2 master 43361 0 2388 45749
#5861 43361 0 2388 45749
+/- 0 0 0 0
libopenthread-rcp.a_1.2 master 27234 0 1532 28766
#5861 27234 0 1532 28766
+/- 0 0 0 0
libopenthread-radio.a_1.2 master 14959 0 174 15133
#5861 14959 0 174 15133
+/- 0 0 0 0

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #5861 (37079d4) into master (d954ae9) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5861      +/-   ##
==========================================
- Coverage   87.14%   87.12%   -0.02%     
==========================================
  Files         372      372              
  Lines       47044    47107      +63     
==========================================
+ Hits        40995    41043      +48     
- Misses       6049     6064      +15     
Impacted Files Coverage Δ
src/core/api/dataset_api.cpp 83.33% <0.00%> (-14.82%) ⬇️
src/core/meshcop/dataset_manager.hpp 76.92% <0.00%> (-7.70%) ⬇️
src/core/thread/mesh_forwarder.hpp 86.66% <0.00%> (-6.67%) ⬇️
src/core/meshcop/dataset_local.cpp 91.46% <0.00%> (-4.88%) ⬇️
src/core/thread/announce_begin_server.cpp 86.95% <0.00%> (-4.35%) ⬇️
src/core/utils/dataset_updater.cpp 80.45% <0.00%> (-3.45%) ⬇️
src/core/meshcop/dataset_manager.cpp 86.17% <0.00%> (-2.44%) ⬇️
src/core/thread/time_sync_service.cpp 96.15% <0.00%> (-1.29%) ⬇️
src/core/meshcop/dataset.cpp 91.12% <0.00%> (-1.03%) ⬇️
src/posix/client.cpp 92.15% <0.00%> (-0.99%) ⬇️
... and 36 more

@Irving-cl Irving-cl force-pushed the upload_core_dump_on_fail branch from 3e347af to 1f6b08a Compare November 25, 2020 05:10
@Irving-cl Irving-cl requested a review from moandor-y November 25, 2020 05:10
.github/workflows/simulation-1.2.yml Outdated Show resolved Hide resolved
script/test Show resolved Hide resolved
.github/workflows/simulation-1.2.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@moandor-y moandor-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@simonlingoogle simonlingoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@Irving-cl Irving-cl requested a review from jwhui November 27, 2020 05:47
@jwhui
Copy link
Member

jwhui commented Nov 30, 2020

Can we add docs somewhere that includes the steps in #5812 (comment)?

@Irving-cl
Copy link
Contributor Author

Can we add docs somewhere that includes the steps in #5812 (comment)?

@jwhui
What about adding the docs in CONTRIBUTING.md and notify the contributors to download the artifacts and report the issue when error happen?

@jwhui
Copy link
Member

jwhui commented Nov 30, 2020

Can we add docs somewhere that includes the steps in #5812 (comment)?

@jwhui
What about adding the docs in CONTRIBUTING.md and notify the contributors to download the artifacts and report the issue when error happen?

@Irving-cl , sounds good to me!

@Irving-cl Irving-cl force-pushed the upload_core_dump_on_fail branch 2 times, most recently from b1323ea to bd7a4de Compare November 30, 2020 06:54
@Irving-cl
Copy link
Contributor Author

@jwhui

Updated CONTRIBUTING.md for instructions.

@Irving-cl Irving-cl force-pushed the upload_core_dump_on_fail branch from bd7a4de to 29bcbc4 Compare November 30, 2020 08:42
@Irving-cl Irving-cl force-pushed the upload_core_dump_on_fail branch from 29bcbc4 to 5365cec Compare November 30, 2020 12:13
@jwhui jwhui requested a review from Vyrastas November 30, 2020 15:36
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Irving-cl Irving-cl requested a review from Vyrastas December 1, 2020 00:53
@Irving-cl
Copy link
Contributor Author

@Vyrastas

The suggested version is much better. Thanks!

@jwhui jwhui merged commit 6956d5e into openthread:master Dec 2, 2020
@Irving-cl Irving-cl deleted the upload_core_dump_on_fail branch December 8, 2020 01:34
gabekassel pushed a commit to gabekassel/openthread that referenced this pull request Jan 21, 2021
…rograms (openthread#5861)

This commit adds action to upload core dumps, so libs and binaries for
1.2 certification. This is intended to solve issues where programs
intermittently crash however hard to reproduce it.

This is added first for thread-1-2 and low-power-packet-verification
first as an experimental work. We can add same actions for other items
when it's necessary.
Abhayakara pushed a commit to Abhayakara/openthread that referenced this pull request Oct 6, 2021
…rograms (openthread#5861)

This commit adds action to upload core dumps, so libs and binaries for
1.2 certification. This is intended to solve issues where programs
intermittently crash however hard to reproduce it.

This is added first for thread-1-2 and low-power-packet-verification
first as an experimental work. We can add same actions for other items
when it's necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[github-actions] upload core dump file and binaries when test program crashes
5 participants