Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform]: replace PlotlyJS with observable Plot (DepMap) #409

Merged
merged 11 commits into from
Jul 24, 2024

Conversation

carcruz
Copy link
Contributor

@carcruz carcruz commented Jul 7, 2024

[Platform]: replace PlotlyJS with observable Plot (DepMap)

This is part of exploratory work to standardize our data viz implementations across the UI. Here, I'm replacing PlotlyJS with Observable Plot.

Todo:

  • Remove Plotly
  • Initial implementation with Plot
    • Dots
    • Binned box
    • Tooltip
    • On click redirection

Issue: opentargets/issues#3366
Deploy preview: https://deploy-preview-409--ot-platform.netlify.app/disease/EFO_0000756/associations

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Check DepMap widget in target profile and target prioritisation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@chinmehta chinmehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍🏻 Looks Good.

@chinmehta chinmehta merged commit 77bb9f6 into main Jul 24, 2024
10 of 11 checks passed
@chinmehta chinmehta deleted the cc-depmap-viz branch July 24, 2024 09:51
ricardo-lourenco pushed a commit to thehyve/ot-ui-apps that referenced this pull request Sep 20, 2024
ricardo-lourenco pushed a commit to thehyve/ot-ui-apps that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants