[Package]: migrate GlobalSearchInput component to TypeScript #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carcruz
requested changes
Jun 18, 2024
There was a problem hiding this comment.
Thanks for your PR.
As we are trying to raise our Typescript standards, can you please provide:
- Type function for
onFocusprop, using FocusEvent type from React - Type function for
onChangeprop, using ChangeEvent type from React - Type for return component, in this case
React.RF
raskolnikov-rodion
force-pushed
the
refactor/global-search-input-ts
branch
from
80c9de7
to
0365e41
Compare
carcruz
approved these changes
Jul 8, 2024
ricardo-lourenco
pushed a commit
to thehyve/ot-ui-apps
that referenced
this pull request
Sep 20, 2024
ricardo-lourenco
pushed a commit
to thehyve/ot-ui-apps
that referenced
this pull request
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate the GlobalSearchInput component to TypeScript.
Issue: opentargets/issues#2871
Type of change
How Has This Been Tested?
Applications were built locally. Component was manually inspected in the UI.
Checklist: