[Platform] Add metadata to variant page #369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
chinmehta
requested changes
May 13, 2024
| @@ -0,0 +1,95 @@ | |||
| import { ProfileHeader as BaseProfileHeader, Field } from "ui"; | |||
There was a problem hiding this comment.
create a new component named as ProfileHeader.tsx which will have all the header data and import it in Profile.tsx page as it will contain other widgets and summary as well
| return ( | ||
| <BaseProfileHeader> | ||
|
|
||
| <> |
There was a problem hiding this comment.
Use a <Box> component to encapsulate the data instead of Fragments
| <> | ||
| <Typography variant="subtitle1" mt={0}>Location</Typography> | ||
| <Field loading={loading} title="GRCh38"> | ||
| {`${metadata.chromosome}:${metadata.position}`} |
There was a problem hiding this comment.
string encapsulation not needed here
| </Box> | ||
| </> | ||
| : <Field key={key} loading={loading} title={key}> | ||
| {String(metadata.inSilicoPredictors[key as keyof InSilicoPredictorsType])} |
There was a problem hiding this comment.
use types in params like: .map(key :InSilicoPredictorsType )
There was a problem hiding this comment.
This doesn't work here - I think since the the key itself is not of type InSilicoPredictorsType.
|
Replaced by PR #376 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added profile to variants page with metadata.
Issue: opentargets/issues#3299
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Load variant page with dev server (e.g. http://localhost:3000/variant/20_31257670_C_T).
Checklist: