libmultipath: fix max_sectors_kb on adding path #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user can change the value of max_sectors_kb on the multipath device and its path devices. So when a path is deleted and then re-added, its value will not be the same as the multipath device. In that case the IOs could be mis-sized. This was originally hit on Lustre FS on: https://jira.whamcloud.com/browse/LU-9551 On reload, this patch re-apply max_sectors_kb value of the multipath device on its path devices. Signed-off-by: Etienne AUJAMES <[email protected]>
|
More information in: https://jira.whamcloud.com/browse/LU-12029 |
|
This looks good to me, but in general, pull requests to multipath-tools are handled using an email based workflow. Can you please send these patches to the dm-devel mailing list, and CC mwilck at suse.com and bmarzins at redhat.com? Thanks. |
Merged
|
Fixed in #68. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user can change the value of max_sectors_kb on the multipath device and its path devices.
So when a path is deleted and then re-added, its value will not be the same as the multipath device. In that case the IOs could be mis-sized.
This was originally hit on Lustre FS on:
https://jira.whamcloud.com/browse/LU-9551
On reload, this patch re-apply max_sectors_kb value of the multipath device on its path devices.