Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make runtime abstraction layer tobe correctly #839

Merged

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Apr 14, 2022

Types

  • 🐛 Bug Fixes

Background or solution

修复框架启动部分消息丢失问题

Changelog

make runtime abstraction layer tobe correctly

@erha19 erha19 requested a review from hacke2 April 14, 2022 14:08
@erha19 erha19 changed the title fix: make runtime-abstraction layer-tobe correctly fix: make runtime abstraction layer tobe correctly Apr 14, 2022
@erha19
Copy link
Member Author

erha19 commented Apr 14, 2022

/publish

@github-actions
Copy link
Contributor

🎉 Pre-Release version 2.16.11-next-1649945571.0 publish successful! You can install prerelease version via npm install [email protected] @erha19

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

Merging #839 (d4b5a5c) into main (83b7588) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d4b5a5c differs from pull request most recent head 8db02ca. Consider uploading reports for the commit 8db02ca to get more accurate results

@@           Coverage Diff           @@
##             main     #839   +/-   ##
=======================================
  Coverage   58.59%   58.60%           
=======================================
  Files        1213     1212    -1     
  Lines       75118    75113    -5     
  Branches    15633    15633           
=======================================
+ Hits        44016    44017    +1     
+ Misses      28342    28337    -5     
+ Partials     2760     2759    -1     
Impacted Files Coverage Δ
packages/connection/src/browser/index.ts 100.00% <ø> (ø)
packages/connection/src/common/proxy.ts 86.95% <ø> (ø)
packages/connection/src/common/message.ts 72.34% <100.00%> (+0.60%) ⬆️
packages/core-browser/src/bootstrap/connection.ts 49.05% <100.00%> (-0.04%) ⬇️
...ages/file-service/src/node/file-service-watcher.ts 68.88% <0.00%> (-0.56%) ⬇️
...erences/src/browser/preference-settings.service.ts 74.83% <0.00%> (+0.64%) ⬆️
...kages/theme/src/browser/workbench.theme.service.ts 72.05% <0.00%> (+0.88%) ⬆️
packages/monaco/src/browser/schema-registry.ts 71.11% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83b7588...8db02ca. Read the comment docs.

@erha19 erha19 force-pushed the fix/connection/make-runtime-abstraction-layer-tobe-correctly branch from 1f550f0 to d4b5a5c Compare April 15, 2022 02:52
@erha19 erha19 force-pushed the fix/connection/make-runtime-abstraction-layer-tobe-correctly branch from d4b5a5c to 31e17c7 Compare April 15, 2022 02:57
@erha19 erha19 force-pushed the fix/connection/make-runtime-abstraction-layer-tobe-correctly branch from 31e17c7 to 8db02ca Compare April 15, 2022 02:58
@erha19
Copy link
Member Author

erha19 commented Apr 15, 2022

/publish

@github-actions
Copy link
Contributor

🎉 Pre-Release version 2.16.11-next-1650004176.0 publish successful! You can install prerelease version via npm install [email protected] @erha19

Aaaaash
Aaaaash previously approved these changes Apr 15, 2022
Copy link
Member

@hacke2 hacke2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit 81dbbb5 into main Apr 15, 2022
@erha19 erha19 deleted the fix/connection/make-runtime-abstraction-layer-tobe-correctly branch April 15, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants